Skip to content

Add a CI check for upstream locale keys that still show OSM wording - #449

Open
Rub21 wants to merge 1 commit into
staging-upstreamfrom
overwrite-locales
Open

Add a CI check for upstream locale keys that still show OSM wording#449
Rub21 wants to merge 1 commit into
staging-upstreamfrom
overwrite-locales

Conversation

@Rub21

@Rub21 Rub21 commented Aug 19, 2026

Copy link
Copy Markdown
Member

This PR adds a CI job and a script that fail when OSM wording still shows up on the OHM site.

  1. Compare config/locales/en.yml (upstream) with config/locales/overrides/en.yml (OHM).
  2. Look for OSM branding in upstream text: OpenStreetMap, OSM, osm.org, State of the Map, switch2osm.
  3. Skip keys the OHM site never renders, plus the ones in KEEP_UPSTREAM_WORDING where the OSM mention is correct.
  4. Anything left renders on OHM, says OSM, and has no override → CI fails and prints the keys.

So when upstream adds a new label with OSM branding, we catch it before it ships.

@Rub21
Rub21 force-pushed the overwrite-locales branch 2 times, most recently from 3120f86 to 7a4c4da Compare August 19, 2026 14:01
@Rub21
Rub21 force-pushed the overwrite-locales branch from 7a4c4da to a7b1bc0 Compare August 19, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants