Added support for EC and DSA keys #180
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kimbeelen Thank you for providing a fix. Could you try resolving the DCO issues? Making sure all commits were signed? |
kimbeelen
force-pushed
the
signature-alg
branch
from
1bc462a to
ff72a55
Compare
Signed-off-by: kimbeelen <[email protected]>
… keys. Signed-off-by: kimbeelen <[email protected]>
Signed-off-by: kimbeelen <[email protected]>
Signed-off-by: kimbeelen <[email protected]>
…different key types Signed-off-by: kimbeelen <[email protected]>
Signed-off-by: kimbeelen <[email protected]>
Signed-off-by: kimbeelen <[email protected]>
Signed-off-by: kimbeelen <[email protected]>
Signed-off-by: kimbeelen <[email protected]>
Signed-off-by: kimbeelen <[email protected]>
Signed-off-by: kimbeelen <[email protected]>
Signed-off-by: kimbeelen <[email protected]>
Signed-off-by: kimbeelen <[email protected]>
kimbeelen
force-pushed
the
signature-alg
branch
from
ff72a55 to
60c6866
Compare
|
@axmsoftware I resolved the DCO issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request provides a solution for Issue #65 by selecting a signature algorithm based on the key passed to the server or client. Default algorithms are used for RSA, DSA and EC keys. Ed25519 and Ed448 keys are not supported by SignXML and therefore not included in this feature.