Skip to content

Conversation

kaushikponnapalli
Copy link
Contributor

Summary

Modified the level 3 example to work with other transcriptions. Currently this will not solve if using PicardShooting due a bug on the dymos side. When that bugfix is merged in, the problem should work with the new transcription.

Related Issues

  • Resolves #

Backwards incompatibilities

None

New Dependencies

None

phase.nonlinear_solver = om.NonlinearRunOnce()
phase.linear_solver = om.LinearRunOnce()
if isinstance(phase.indep_states, om.ImplicitComponent):
if isinstance(phase.options['transcription'], dm.Radau) and isinstance(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be leftover code from some other work, or maybe it is the start of supporting Shooting in level 2. The level3 example doesn't use aviary_group.


seg_ends, _ = dm.utils.lgl.lgl(5 + 1)
transcription = dm.Radau(
num_segments=5,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This transcription isn't used.

@Kenneth-T-Moore
Copy link
Member

Kenneth-T-Moore commented Sep 18, 2025

I think the actual shooting example file was mistakenly omitted from this PR.

EDIT - Reread the description. I guess we are supposed to modify this after the dymos bugfix. Next steps are unclear at present though.

Copy link
Member

@Kenneth-T-Moore Kenneth-T-Moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is likely missing the example.

@jkirk5
Copy link
Contributor

jkirk5 commented Sep 23, 2025

I think the actual shooting example file was mistakenly omitted from this PR.

EDIT - Reread the description. I guess we are supposed to modify this after the dymos bugfix. Next steps are unclear at present though.

Once we know that fix is available we can try and convert the example and update our min dymos version. We shouldn't merge until we get to that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants