-
Notifications
You must be signed in to change notification settings - Fork 104
Level 3 Example Shooting #866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
phase.nonlinear_solver = om.NonlinearRunOnce() | ||
phase.linear_solver = om.LinearRunOnce() | ||
if isinstance(phase.indep_states, om.ImplicitComponent): | ||
if isinstance(phase.options['transcription'], dm.Radau) and isinstance( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be leftover code from some other work, or maybe it is the start of supporting Shooting in level 2. The level3 example doesn't use aviary_group.
|
||
seg_ends, _ = dm.utils.lgl.lgl(5 + 1) | ||
transcription = dm.Radau( | ||
num_segments=5, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This transcription isn't used.
I think the actual shooting example file was mistakenly omitted from this PR. EDIT - Reread the description. I guess we are supposed to modify this after the dymos bugfix. Next steps are unclear at present though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is likely missing the example.
Once we know that fix is available we can try and convert the example and update our min dymos version. We shouldn't merge until we get to that point. |
Summary
Modified the level 3 example to work with other transcriptions. Currently this will not solve if using PicardShooting due a bug on the dymos side. When that bugfix is merged in, the problem should work with the new transcription.
Related Issues
Backwards incompatibilities
None
New Dependencies
None