-
Notifications
You must be signed in to change notification settings - Fork 105
BWB components in Geometry/flops_based subsysterms #872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xjjiang
wants to merge
58
commits into
OpenMDAO:main
Choose a base branch
from
xjjiang:BWB_FLOPS_geom
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y created data type DetailedWing which has three values: TO_PROVIDE(1), TO_COMPUTE(-1), NOT_TO_USE(0)
…ry call. Keep the function update_aviary_options() as a place holder for possible future use.
…detailed.py to test_bwb_wing_detailed.py
… boolean; create new variable Aircraft.BWB.DETAILED_WING_PROVIDED
Update by Ken
…rom cargo_containers.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the BWB aircraft geometry subsystem based on FLOPS design.
The FLOPS based geometry subsystems are shown in the following table. The left column is for the conventional aircraft and the right column is for BWB aircraft. In both case, user can choose a simple layout or a detailed layout.
FLOPS has multiple scenarios of fuselage layout algorithms. We choose to implement the simplest and most detailed algorithms in Aviary. Other scenarios can be added if needed.
The BWB aircraft always requires a detailed wing distribution. It is either given (
BWBUpdateDetailedWingDist
) or created (BWBComputeDetailedWingDist
).Aircraft.BWB.MAX_NUM_BAYS
is changed from an option to Aviary variable because it needs to be updated during a run.Aircraft.Wing.INPUT_STATION_DIST
is still an option. We created a variableBWB_INPUT_STATION_DIST
from it.Comparision of Conventional Aircraft and BWB Aircraft
SimpleCabinLayout
orDetailedCabinLayout
BWBSimpleCabinLayout
orBWBDetailedCabinLayout
BWBUpdateDetailedWingDist
orBWBComputeDetailedWingDist
FuselagePrelim
BWBFuselagePrelim
WingPrelim
BWBWingPrelim
_Prelim
_Prelim
_Wing
_BWBWing
_Tail
_Tail
_Fuselage
_BWBFuselage
_FuselageRatios
_FuselageRatios
Nacelles
Nacelles
Canard
Canard
WingCharacteristicLength
BWBWingCharacteristicLength
OtherCharacteristicLengths
OtherCharacteristicLengths
TotalWettedArea
TotalWettedArea
As we see in the above table, some geometrical components have no special treatments in the BWB case (e.g.
Nacelles
and_Tail
). So, the new implementation of BWB geometry uses the same components in conventional aircraft.In the unit tests, we choose two typical cases:
BWBSimpleCabinLayout
+BWBComputeDetailedWingDist
andBWBDetailedCabinLayout
+BWBUpdateDetailedWingDist
. Both are checked against FLOPS runs and they both match pretty well.None of the current Aviary model that uses FLOPS based geometry carry out fuselage cabin layout computation. If fuselage dimension variables are missing, they will be computed using GASP based geometry.
Related Issues
Backwards incompatibilities
None
New Dependencies
None