Remove non-default recorder locations in preparation for Jason's PR 870. #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmbenne3
approved these changes
Oct 6, 2025
|
Why is this only a problem for PR#870? |
In PR 870, Jason removed the argument for setting the report name/location, but he forgot to take it out of a few of the benchmarks where we set it. Note, I think we only set it in those benchmarks because they were cut and paste from an earlier one where, for some reason, we set the report name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This will allow #870 to pas the benchmarks.
Related Issues
Backwards incompatibilities
None
New Dependencies
None