Skip to content

Refactor PayPal Module #4838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 51 commits into
base: main
Choose a base branch
from
Draft

Refactor PayPal Module #4838

wants to merge 51 commits into from

Conversation

@hirale
Copy link
Contributor

@hirale hirale commented Jun 22, 2025 •
edited
Loading

Description (*)

Refactor PayPal module to meet PayPal REST APIs with https://github.com/paypal/PayPal-PHP-Server-SDK

Related Pull Requests

✅ Current Status

The standard purchase flow has been fully tested and works as expected.
It supports:

  • Refund
  • Void
  • Authorize
  • Capture

For Authorize transactions, I have created a cronjob to process automatic re-authorize after 3 days honor period.
You can find more details here:
👉 PayPal Checkout Payment Intent Documentation

🔜 Next Steps (Help Needed)

I’ll need help with the following:

  1. Recurring Payments

    • Development and testing of recurring payment functionality.

  2. Compatibility with One Step Checkout Extensions

    • Review and ensure compatibility with popular one-step checkout modules.

  3. Code Testing

    • Improve test coverage.
    • Identify critical areas needing unit or integration tests.
    • Validate edge cases and PayPal SDK integration scenarios.

  4. Backwards Compatibility

    • Ensure smooth backward compatibility where possible.
    • The current implementation removes all old PayPal payment methods from the install scripts, keeping only the corresponding payment title config.
    • Review upgrade paths for existing merchants migrating from previous PayPal integration to this new module version.

📦 Versioning Notes

  • The module version has been bumped directly to 2.0.0.0.
  • All previous PayPal payment methods and install scripts have been removed.
  • Only config-based payment titles remain for legacy visibility where needed.

📚 Reference

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added Component: PayPal Relates to Mage_Paypal Component: Core Relates to Mage_Core Template : admin Relates to admin template Component: Sales Relates to Mage_Sales Template : rwd Relates to rwd template Template : base Relates to base template Component: Adminhtml Relates to Mage_Adminhtml Component: Review Relates to Mage_Review Component: Downloadable Relates to Mage_Downloadable Component: Bundle Relates to Mage_Bundle translations Relates to app/locale composer Relates to composer.json JavaScript Relates to js/* XML Layout phpstan PHPStorm phpunit labels Jun 22, 2025
@hirale hirale marked this pull request as draft June 22, 2025 15:15
@github-actions github-actions bot removed Component: Tax Relates to Mage_Tax Component: Shipping Relates to Mage_Shipping Component: Rule Relates to Mage_Rule Component: Payment Relates to Mage_Payment Component: Newsletter Relates to Mage_Newsletter Component: Index Relates to Mage_Index Component: CatalogIndex Relates to Mage_CatalogIndex Component: Api2 Relates to Mage_Api2 Component: Log Relates to Mage_Log Component: ImportExport Relates to Mage_ImportExport Component: Directory Relates to Mage_Directory Component: CatalogSearch Relates to Mage_CatalogSearch shell Relates to shell scripts Component: Centinel Relates to Mage_Centinel Component: Dataflow Relates to Mage_Dataflow Component: Uploader Relates to Mage_Uploader Component: Rss Relates to Mage_Rss Component: Paygate Relates to Mage_Paygate Component: lib/* Relates to lib/* errors Relates to error pages rector labels Jul 11, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 14, 2025

Quality Gate Passed Quality Gate passed

Issues
10 New issues
8 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.1% Duplication on New Code

See analysis details on SonarQube Cloud

hirale and others added 4 commits October 2, 2025 21:41
@hirale
Merge branch 'main' into paypal
d123b17
@hirale
feat(paypal): adjust cart totals for rounding instead of tax discrepancy
7e77dce 
Refactor the cart total adjustment logic to handle rounding differences
for both item prices and taxes. This replaces the previous tax-only
discrepancy adjustment.

The change includes:
- Renaming the method from adjustCartTotalsForTaxDiscrepancy to
  adjustCartTotalsForRounding
- Calculating rounding differences for item prices and taxes separately
- Adjusting discount amounts or adding rounding adjustment items as needed
- Updating related helper text for rounding adjustments
- Fixing indentation for payment method comments
@hirale
refactor(paypal): align indentation for payment method comments
83cbe23
@kiatng
Merge branch 'main' into paypal
220817c
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2025

Quality Gate Passed Quality Gate passed

Issues
118 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.1% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@empiricompany empiricompany empiricompany left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Component: Adminhtml Relates to Mage_Adminhtml Component: Bundle Relates to Mage_Bundle Component: Core Relates to Mage_Core Component: Downloadable Relates to Mage_Downloadable Component: PayPal Relates to Mage_Paypal Component: Review Relates to Mage_Review Component: Sales Relates to Mage_Sales composer Relates to composer.json JavaScript Relates to js/* phpstan PHPStorm phpunit Template : admin Relates to admin template Template : base Relates to base template Template : rwd Relates to rwd template translations Relates to app/locale XML Layout

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hirale @empiricompany @sreichel @kiatng