PHP8.5: fix null array offset

[sreichel]

https://github.com/OpenMage/magento-lts/actions/runs/18709139113/job/53353233192

[Copilot]

Pull Request Overview

This PR addresses null array offset deprecation warnings in PHP 8.5 by adding null checks and type coercion before array access operations. The changes prevent potential issues where null values are used as array keys or offsets.

Key Changes:

• Added null checks with empty string fallback before array key access in multiple methods
• Added explicit string type casting for array keys to prevent null offset warnings
• Removed a potentially problematic curl_close() call that could fail if the resource was already null

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
lib/Varien/Http/Adapter/Curl.php	Removed curl_close call to prevent errors when resource is null
lib/Varien/Data/Collection.php	Added null check converting null to empty string before array access
app/code/core/Mage/Index/Model/Indexer/Abstract.php	Added null check converting null to empty string before array access
app/code/core/Mage/Core/Controller/Varien/Router/Standard.php	Added string cast to prevent null as array key
app/code/core/Mage/CatalogInventory/Model/Stock/Status.php	Added string cast to prevent null as array key
app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price.php	Added null check converting null to empty string before array access
app/code/core/Mage/Catalog/Model/Product/Type.php	Added string cast to prevent null as array key

Comments suppressed due to low confidence (1)

app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price.php:1

• Converting null to empty string will result in a less informative error message on line 319 ('Unsupported product type ""'). Consider checking for null explicitly and throwing a more specific exception like 'Product type ID cannot be null' to aid debugging.

<?php

[Copilot]

Converting null to an empty string could mask logic errors where null IDs are passed unintentionally. Consider adding validation to throw an exception or log a warning when null is passed, or return null immediately instead of treating it as a valid key. This would make debugging easier and prevent unexpected behavior where null and empty string IDs are treated as equivalent.

Suggested change

	$idValue = '';
	return null;

[sreichel]

See https://onlinephp.io?s=s7Hn5VIpSyxSsFWIzivNyVGwtVMwjLXm5QKKxaeU5hZoaICkNTWtAQ%2C%2C&v=8.4.10%2C8.1.33%2C8.3.8%2C8.2.12

[Copilot]

Converting null entity to an empty string could hide incorrect method calls. Consider adding type hints (e.g., ?string $entity) and either returning early with a default value or throwing an exception when null is passed, as null likely indicates invalid usage rather than a valid empty entity name.

Suggested change

	*/
	public function matchEntityAndType($entity, $type)
	{
	if ($entity === null) {
	$entity = '';
	* @throws InvalidArgumentException if $entity is null
	*/
	public function matchEntityAndType(?string $entity, string $type)
	{
	if ($entity === null) {
	throw new InvalidArgumentException('Entity name must not be null.');

[sreichel]

No,https://onlinephp.io?s=s7Hn5VIpSyxSsFWIzivNyVGwtVMwjLXm5QKKxaeU5hZoaICkNTWtAQ%2C%2C&v=8.4.10%2C8.1.33%2C8.3.8%2C8.2.12

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Hanmac]

Why not like this?

$productTypeId ??= '';