Skip to content

Features for MCTP Control Protocol #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −4
Open

Features for MCTP Control Protocol #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d08d3c
Provide destination EID to transport binding
embediver Nov 20, 2025
31e2bc8
Don't drop messages with physical addressing
embediver Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,10 @@ impl<S: Sender, const MAX_LISTENER_HANDLES: usize, const MAX_REQ_HANDLES: usize>
return Ok(());
};

if msg.dest != own_eid {
// Drop messages if eid does not match (for now)
if msg.dest != own_eid && msg.dest != Eid(0) {
// Drop messages if eid does not match (for now).
// EID 0 messages are used for physical addressing
// and will thus be processed.
return Ok(());
}

Expand Down Expand Up @@ -221,7 +223,7 @@ impl<S: Sender, const MAX_LISTENER_HANDLES: usize, const MAX_REQ_HANDLES: usize>
Some(cookie),
)?;

self.sender.send_vectored(frag, bufs)
self.sender.send_vectored(eid, frag, bufs)
}

/// Receive a message associated with a [`AppCookie`]
Expand Down Expand Up @@ -326,7 +328,8 @@ impl<S: Sender, const MAX_LISTENER_HANDLES: usize, const MAX_REQ_HANDLES: usize>
/// Implemented by a transport binding for sending packets.
pub trait Sender {
/// Send a packet fragmented by `fragmenter` with the payload `payload`
fn send_vectored(&mut self, fragmenter: Fragmenter, payload: &[&[u8]]) -> Result<Tag>;
fn send_vectored(&mut self, eid: Eid, fragmenter: Fragmenter, payload: &[&[u8]])
-> Result<Tag>;
/// Get the MTU of a MCTP packet fragment (without transport headers)
fn get_mtu(&self) -> usize;
}
Expand All @@ -345,6 +348,7 @@ mod test {
impl Sender for DoNothingSender {
fn send_vectored(
&mut self,
_eid: Eid,
fragmenter: mctp_estack::fragment::Fragmenter,
payload: &[&[u8]],
) -> core::result::Result<mctp::Tag, mctp::Error> {
Expand All @@ -364,6 +368,7 @@ mod test {
impl<const MTU: usize> Sender for BufferSender<'_, MTU> {
fn send_vectored(
&mut self,
_eid: Eid,
mut fragmenter: mctp_estack::fragment::Fragmenter,
payload: &[&[u8]],
) -> core::result::Result<mctp::Tag, mctp::Error> {
Expand Down
Loading