Skip to content

Conversation

@thomassedlmayer
Copy link
Contributor

@thomassedlmayer thomassedlmayer commented Apr 11, 2025

This PR aims to adapt the vehicle type definitions and descriptions that are defined by the OpenX Traffic Participants Specification.

I also replaced the old meaningless ("Vehicle is a car") descriptions with the ones of the OpenX specification.

@yash-shah-asam Could you check if there is a permalink to the OpenX specification, I could use? I think it would be reasonable to include a permalink to the specification and somehow signify that OSI tries to adhere to these definitions.

I think there a still some issues open for discussion:

  1. OSI currently defines TYPE_DELIVERY_VAN which should probably be deprecated (as it contains a role). I added the preferred alias TYPE_VAN.
    Decision from TrafficParticipant Working Group: Deprecate TYPE_DELIVERY_VAN in favor of TYPE_VAN in order to move away from describing roles.
  2. OSI currently defines bicycles to not include a motor ("Vehicle is a bicycle (without motor and specific lights)") whereas the OpenX specification includes motor-assisted bicycles.
  3. TYPE_MOTORBIKE contradicts the naming in the OpenX specification ("Motorcycle"). I added an alias. I'm not sure if we should deprecate TYPE_MOTORBIKE or just keep both.
    Decision from TrafficParticipant Working Group: Deprecate TYPE_MOTORBIKE, introduce TYPE_MOTORCYCLE
  4. I added TYPE_MICROMOBILITY_DEVICE which includes stand-up scooters but OSI already defines the type TYPE_STANDUP_SCOOTER. Should it be deprecated? It seems like an issue that in the description of micro-mobility devices the stand-up scooter is even mentioned as an example.
    Decision from TrafficParticipant Working Group: Adapt TrafficParticipant Specification to introduce types for stand-up scooters instead of including them in the more generic category for micro-mobility devices.

Apart from these issues, the changes are relatively straightforward and don't contradict the current OSI definitions from my point of view.

@jakobkaths

@thomassedlmayer thomassedlmayer added the Harmonisation The Group in the ASAM development project working on harmonisation with other standards. label Apr 11, 2025
@thomassedlmayer thomassedlmayer added this to the V3.7.1 milestone Apr 11, 2025
@thomassedlmayer thomassedlmayer requested a review from pmai April 11, 2025 13:57
@thomassedlmayer thomassedlmayer force-pushed the adapt-vehicle-harmonization branch from 2b22a42 to 45f045f Compare April 14, 2025 08:31
@jakobkaths
Copy link
Contributor

Thanks for the initiative and quick implementation, @thomassedlmayer ! I would agree to deprecate DELIVERY_VAN and MOTORBIKE. Regarding the BICYCLE and what they do / don't include let's dicuss in the group again. Same for the scooter...


// Vehicle is a wheelchair.
//
TYPE_WHEELCHAIR = 15;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Wheelchair was sorted into Micromobility Device as well in the OpenX definition. We have to make sure that we don't keep surplus definitions here, either. But again, we could discuss in the group if this is maybe prominent enough to spearate it into a dedicated type.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The discussion result was to separate out both wheelchair and stand-up scooter types from micro-mobility device in the harmonized traffic participation specification and specifically state this in the description.

I adopted the changed descriptions from here.

Co-authored-by: jakobkaths <[email protected]>
Signed-off-by: Thomas Sedlmayer <[email protected]>
@thomassedlmayer thomassedlmayer force-pushed the adapt-vehicle-harmonization branch 3 times, most recently from 6044612 to 161cd73 Compare June 12, 2025 15:15
@thomassedlmayer thomassedlmayer force-pushed the adapt-vehicle-harmonization branch from 161cd73 to 60af20e Compare June 12, 2025 15:23
- Add note on compliance with ASAM TrafficParticipants Specification
- Adapt note on OSI's obsolete type mapping issue (switch to past tense, revise wording)
- Remove obsolete note on difficult distinction between OSI's vehicle types

Signed-off-by: Thomas Sedlmayer <[email protected]>
@thomassedlmayer thomassedlmayer force-pushed the adapt-vehicle-harmonization branch from f432dcc to 1338c79 Compare June 13, 2025 09:01
Signed-off-by: Thomas Sedlmayer <[email protected]>
@thomassedlmayer thomassedlmayer added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Sep 24, 2025
@thomassedlmayer
Copy link
Contributor Author

@jakobkaths I synced the wording/grammar changes from the traffic participant specification and put the label ReadyForCCB so this can be reviewed this in the CCB tomorrow morning. Could you also have a look again?

Copy link
Contributor

@jakobkaths jakobkaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, I only have some comments regarding the standards "brand names". Also, in our discussions we said that the UN categories etc. shouldn't really be normative, but more like a hint, but I would personally be okay with it this way as the "note" and the "roughly" indicate this.

Signed-off-by: Thomas Sedlmayer <[email protected]>
@AsamDiegoSanchez
Copy link

OSI CCB meeting 25.09.2025: group has approved the PR.

@pmai pmai merged commit 4304139 into master Sep 25, 2025
10 checks passed
@pmai pmai deleted the adapt-vehicle-harmonization branch September 25, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Harmonisation The Group in the ASAM development project working on harmonisation with other standards. ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants