-
Notifications
You must be signed in to change notification settings - Fork 130
Adapt vehicle types from openx harmonization #863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Thomas Sedlmayer <[email protected]>
2b22a42 to
45f045f
Compare
|
Thanks for the initiative and quick implementation, @thomassedlmayer ! I would agree to deprecate DELIVERY_VAN and MOTORBIKE. Regarding the BICYCLE and what they do / don't include let's dicuss in the group again. Same for the scooter... |
|
|
||
| // Vehicle is a wheelchair. | ||
| // | ||
| TYPE_WHEELCHAIR = 15; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Wheelchair was sorted into Micromobility Device as well in the OpenX definition. We have to make sure that we don't keep surplus definitions here, either. But again, we could discuss in the group if this is maybe prominent enough to spearate it into a dedicated type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The discussion result was to separate out both wheelchair and stand-up scooter types from micro-mobility device in the harmonized traffic participation specification and specifically state this in the description.
I adopted the changed descriptions from here.
Co-authored-by: jakobkaths <[email protected]> Signed-off-by: Thomas Sedlmayer <[email protected]>
6044612 to
161cd73
Compare
Signed-off-by: Thomas Sedlmayer <[email protected]>
161cd73 to
60af20e
Compare
- Add note on compliance with ASAM TrafficParticipants Specification - Adapt note on OSI's obsolete type mapping issue (switch to past tense, revise wording) - Remove obsolete note on difficult distinction between OSI's vehicle types Signed-off-by: Thomas Sedlmayer <[email protected]>
f432dcc to
1338c79
Compare
Signed-off-by: Thomas Sedlmayer <[email protected]>
|
@jakobkaths I synced the wording/grammar changes from the traffic participant specification and put the label ReadyForCCB so this can be reviewed this in the CCB tomorrow morning. Could you also have a look again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, I only have some comments regarding the standards "brand names". Also, in our discussions we said that the UN categories etc. shouldn't really be normative, but more like a hint, but I would personally be okay with it this way as the "note" and the "roughly" indicate this.
Signed-off-by: Thomas Sedlmayer <[email protected]>
|
OSI CCB meeting 25.09.2025: group has approved the PR. |
This PR aims to adapt the vehicle type definitions and descriptions that are defined by the OpenX Traffic Participants Specification.
I also replaced the old meaningless ("Vehicle is a car") descriptions with the ones of the OpenX specification.
@yash-shah-asam Could you check if there is a permalink to the OpenX specification, I could use? I think it would be reasonable to include a permalink to the specification and somehow signify that OSI tries to adhere to these definitions.
I think there a still some issues open for discussion:
TYPE_DELIVERY_VANwhich should probably be deprecated (as it contains a role). I added the preferred aliasTYPE_VAN.Decision from TrafficParticipant Working Group: Deprecate
TYPE_DELIVERY_VANin favor ofTYPE_VANin order to move away from describing roles.TYPE_MOTORBIKEcontradicts the naming in the OpenX specification ("Motorcycle"). I added an alias. I'm not sure if we should deprecateTYPE_MOTORBIKEor just keep both.Decision from TrafficParticipant Working Group: Deprecate
TYPE_MOTORBIKE, introduceTYPE_MOTORCYCLETYPE_MICROMOBILITY_DEVICEwhich includes stand-up scooters but OSI already defines the typeTYPE_STANDUP_SCOOTER. Should it be deprecated? It seems like an issue that in the description of micro-mobility devices the stand-up scooter is even mentioned as an example.Decision from TrafficParticipant Working Group: Adapt TrafficParticipant Specification to introduce types for stand-up scooters instead of including them in the more generic category for micro-mobility devices.
Apart from these issues, the changes are relatively straightforward and don't contradict the current OSI definitions from my point of view.
@jakobkaths