Skip to content

dev: make failed compiles fail the build #894

Description

@0xisk

yarn compile:* prints Compiled <file> and exits 0 even when compact compile fails and writes no artifact. @openzeppelin/compact-builder 0.0.4 runs the compiler under script -qc, and script without -e returns 0 regardless of the child's status. A mock with a wrong import path passed CI-style compiles during the preset refactors and was only caught by counting artifacts.

Upstream fixed it in compact-tools #162, shipped as compact-builder 0.0.5. We never receive it: @openzeppelin/compact-cli ^0.0.3 pins builder ^0.0.4, which on a 0.0.x line excludes 0.0.5. compact-cli 0.1.1 pins builder ^0.0.5 and its deployer dependency is now published. Bump the cli to ^0.1.1 (Node 24, which the repo already targets), and pass --feature-zkir-v3 on the umbrella compile and build scripts, which the honest exit code shows have been failing silently for the ECDSA contracts.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildImprovements related to package changesenhancementNew feature or request

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions