Skip to content

Add account factory #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Add account factory #576

wants to merge 4 commits into from

Conversation

Amxx
Copy link
Contributor

@Amxx Amxx commented Jun 19, 2025

No description provided.

@Amxx Amxx requested review from ernestognw and ericglau June 19, 2025 22:12
Copy link
Member

@ericglau ericglau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks like a good approach.

`}`,
`return instance;`,
]).split('\n'),
{ name: 'create', kind: 'public' as const, args, returns: [ 'address' ] },
Copy link
Member

@ericglau ericglau Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function name is create but the cloning is using create2. These don't need to match but should we make it clearer that this deploys accounts using create2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants