[Stellar] Add rust ci compilation #594
Open
+3,071
−629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Eric Lau <[email protected]>
…contracts-wizard into use-stellar-scaffold-cli-upgrade
…contracts-wizard into add-rust-ci-compilation
…-wizard into add-rust-ci-compilation
CoveMB
force-pushed
the
add-rust-ci-compilation
branch
from
d9dbf4b to
ed05184
Compare
CoveMB
force-pushed
the
add-rust-ci-compilation
branch
from
3052877 to
2e380ad
Compare
CoveMB
force-pushed
the
add-rust-ci-compilation
branch
from
2e380ad to
f6988bc
Compare
ozgunozerk
reviewed
Jul 17, 2025
| # id: get-scaffold-sha | ||
| # run: | | ||
| # echo "sha=$(git ls-remote https://github.com/ahalabs/scaffold-stellar HEAD | cut -f1)" >> $GITHUB_OUTPUT | ||
| echo "sha=ebf79b8a57ad1b51a46162afd98ca05c648085fe" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
was this a debug thing?
|
Didn't spend much time on it, thought asking it would be more efficient. I saw Are they embedded into I think cargo tests happen here: Just wanted to double check 👍 |
brozorec
approved these changes
Jul 21, 2025
| const asyncExec = promisify(exec); | ||
|
|
||
| export const runCargoTest = async (t: ExecutionContext, temporaryFolder: string) => { | ||
| const result = await asyncExec(`cd "${temporaryFolder}" && RUSTFLAGS="-D warnings" cargo test`); |
There was a problem hiding this comment.
Suggested change
| const result = await asyncExec(`cd "${temporaryFolder}" && RUSTFLAGS="-D warnings" cargo test`); | |
| const result = await asyncExec(`cd "${temporaryFolder}" && cargo test`); |
we can make the compilation test pass by ignoring the warnings for the moment and we work on getting rid of them in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add compilation tests
Description