-
Notifications
You must be signed in to change notification settings - Fork 12.2k
Add RLP library #5680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add RLP library #5680
Conversation
Co-authored-by: Hadrien Croubois <[email protected]>
Co-authored-by: Arr00 <[email protected]>
🦋 Changeset detectedLatest commit: da61a5e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Comment |
contracts/utils/RLP.sol
Outdated
* NOTE: This is the strict RLP spec interpretation where false represents "empty". | ||
* Use this for strict RLP spec compliance; use {encode} for ecosystem compatibility. | ||
*/ | ||
function encodeStrict(bool value) internal pure returns (bytes memory) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the documentation, this has the same behavior as encode(bool)
. If there is no difference between the two, I'd only keep one.
We should decide weither we are ok with the following feature:
Overall, we should also discuss naming of the functions in RLP.sol. |
Requires:
Memory
utility library #5189reverseBits
operations to Bytes.sol #5724clz(bytes)
andclz(uint256)
functions #5725PR Checklist
npx changeset add
)