Skip to content

Conversation

ernestognw
Copy link
Member

@ernestognw ernestognw commented May 10, 2025

Copy link

changeset-bot bot commented May 10, 2025

🦋 Changeset detected

Latest commit: da61a5e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ernestognw ernestognw changed the title Add RLP library Add RLP and TrieProof libraries May 11, 2025
@ernestognw ernestognw added this to the 5.x milestone Jun 4, 2025
Copy link

coderabbitai bot commented Aug 27, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

* NOTE: This is the strict RLP spec interpretation where false represents "empty".
* Use this for strict RLP spec compliance; use {encode} for ecosystem compatibility.
*/
function encodeStrict(bool value) internal pure returns (bytes memory) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the documentation, this has the same behavior as encode(bool). If there is no difference between the two, I'd only keep one.

@Amxx
Copy link
Collaborator

Amxx commented Sep 10, 2025

We should decide weither we are ok with the following feature:

  • Memory slices (in memory.sol ?)
  • Bytes accumulator (in bytes.sol ? in a dedicated file under struct ?)
  • RLP encoder interface (uses Bytes accumulator)

Overall, we should also discuss naming of the functions in RLP.sol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants