Skip to content

feat: add Erc1155Holder contract + use type aliases for FixedBytes<N> #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 24, 2025

Conversation

bidzyyys
Copy link
Collaborator

@bidzyyys bidzyyys commented Jul 23, 2025

Resolves #363

PR Checklist

  • Tests
  • Documentation
  • Changelog

@bidzyyys bidzyyys linked an issue Jul 23, 2025 that may be closed by this pull request
1 task
Copy link

netlify bot commented Jul 23, 2025

Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit 6d82d84
🔍 Latest deploy log https://app.netlify.com/projects/contracts-stylus/deploys/6880b746ab292100080b594b

@bidzyyys bidzyyys self-assigned this Jul 23, 2025
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

Attention: Patch coverage is 92.45283% with 8 lines in your changes missing coverage. Please review.

Project coverage is 86.1%. Comparing base (8d1c883) to head (6d82d84).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
contracts/src/token/erc20/extensions/permit.rs 0.0% 4 Missing ⚠️
contracts/src/token/erc1155/mod.rs 66.6% 1 Missing ⚠️
contracts/src/token/erc20/extensions/erc4626.rs 50.0% 1 Missing ⚠️
contracts/src/token/erc20/extensions/wrapper.rs 50.0% 1 Missing ⚠️
contracts/src/token/erc721/extensions/wrapper.rs 66.6% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
contracts-proc/src/interface_id.rs 90.6% <100.0%> (ø)
contracts-proc/src/lib.rs 100.0% <ø> (ø)
...tracts/src/access/control/extensions/enumerable.rs 92.0% <100.0%> (ø)
contracts/src/access/control/mod.rs 98.6% <100.0%> (ø)
contracts/src/access/ownable.rs 89.1% <100.0%> (ø)
contracts/src/access/ownable_two_step.rs 100.0% <100.0%> (ø)
contracts/src/finance/vesting_wallet.rs 57.2% <100.0%> (ø)
contracts/src/token/common/erc2981.rs 99.1% <100.0%> (ø)
...racts/src/token/erc1155/extensions/metadata_uri.rs 100.0% <100.0%> (ø)
contracts/src/token/erc1155/extensions/supply.rs 81.7% <100.0%> (ø)
... and 16 more

Copy link
Collaborator

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@qalisander qalisander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@bidzyyys bidzyyys merged commit 18eff06 into main Jul 24, 2025
25 checks passed
@bidzyyys bidzyyys deleted the feature/erc1155-holder branch July 24, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: ERC1155Holder
3 participants