Skip to content

Conversation

@koji
Copy link
Contributor

@koji koji commented Nov 17, 2025

Overview

fix deck view container styling in visualization page

design
https://www.figma.com/design/Cghh742xREcvLa5DmPETCX/Feature--Protocol-Visualizer?node-id=7126-69274&m=dev

close RQA-4886

Test Plan and Hands on Testing

  • click a protocol in protocol landing page
  • click Visualization button
  • change Window size and resize the columns' width

Describe your testing of the PR. Emphasize testing not reflected in the code. Attach protocols, logs, screenshots and any other assets that support your testing.

Changelog

  • create CSS module file for DeckView container
  • update the right col's min/max width

Review requests

Risk assessment

low

fix deck view container styling

close RQA-4866
@koji koji requested review from jerader and ncdiehl11 November 17, 2025 19:49
@koji koji marked this pull request as ready for review November 17, 2025 19:49
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! lgtm after you fix the lint error

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.83%. Comparing base (2bc10ef) to head (785dda5).
⚠️ Report is 1 commits behind head on edge.

Files with missing lines Patch % Lines
...sktop/Protocols/ProtocolVisualization/DeckView.tsx 0.00% 13 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #20179      +/-   ##
==========================================
- Coverage   56.84%   56.83%   -0.01%     
==========================================
  Files        3577     3577              
  Lines      298531   298534       +3     
  Branches    42209    42213       +4     
==========================================
  Hits       169686   169686              
- Misses     128619   128622       +3     
  Partials      226      226              
Flag Coverage Δ
step-generation 5.48% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...cols/ProtocolVisualization/VisualizerContainer.tsx 61.06% <ø> (ø)
...sktop/Protocols/ProtocolVisualization/DeckView.tsx 6.13% <0.00%> (-0.09%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@koji koji merged commit bfadb7d into edge Nov 19, 2025
39 of 40 checks passed
@koji koji deleted the fix_RQA-4866 branch November 19, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants