forked from ClosureTree/closure_tree
-
Notifications
You must be signed in to change notification settings - Fork 0
Raise error when advisory lock cannot be acquired #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
398e520
to
5787303
Compare
kenrose
reviewed
Mar 19, 2025
f213213
to
d9749ba
Compare
81a4b14
to
618ef8a
Compare
466b321
to
cad9d07
Compare
83e3782
to
a21a037
Compare
a21a037
to
0e6fbf5
Compare
d9249be
to
ef54cd3
Compare
ef54cd3
to
ae7b44f
Compare
eapache-opslevel
approved these changes
Mar 20, 2025
ahh I forgot to squash my commits 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gitlab Issue: https://gitlab.com/jklabsinc/OpsLevel/-/issues/13122
I found traces where jobs fail with a lock timeout after 50s when inserting into
entity_node_hierarchy
so that means our jobs do fail if the actual insert is taking long.But there are traces (example) where the job sits for minutes just doing
SELECT GET_LOCK
until it gets shutdown by sidekiq. TheSELECT GET_LOCK
comes from the closure_tree gem and the gem always callswith_advisory_lock
without any options which means that it waits indefinitely for the lock.So this MR uses
with_advisory_lock!
so that it raises an error if we can't get the lock instead of just waiting indefinitely so that the jobs will end up in the dead set if there's a lot of contention. https://github.com/ClosureTree/with_advisory_lock/blob/master/lib/with_advisory_lock/concern.rb#L16