Repository navigation
Achievements: Add in-game leaderboard overlay toggle - #12698
Conversation
There was a problem hiding this comment.
Thank you for submitting a contribution to PCSX2
As this is your first pull request, please be aware of the contributing guidelines.
Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.
Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!
|
Might also be a good to make the commit to do something like Achievements:Add in-game leaderboard overlay toggle. Or hope while merging it's changed. I'll run workflows for now because it's your first time. |
d6c3d68 to
71a170a
Compare
|
I accidentally opened the PR for the wrong branch, I fixed the commit there so that the description is correct. |
71a170a to
a607118
Compare
|
While rebasing my changes, I noticed the notification position setting was in the wrong section, so I took the liberty to move it to the correct place and also to clarify in the help text that they apply to leaderboards as well. If that's not appropriate, I can open a separate PR for it. |
|
can this be rebased ? |
739a163 to
df81896
Compare
df81896 to
4922a0f
Compare
|
Good catch, I changed the text to remove the reference to a specific position |
kamfretoz
left a comment
There was a problem hiding this comment.
Tested both normal and learboard overlay, works.

Description of Changes
Adds a separate toggle for in-game leaderboard overlays, as suggested in #12676.
Rationale behind Changes
Being able to separately use achievement and leaderboard overlays, so that one can keep only the information they care about on the screen.
Suggested Testing Steps
Toggling both settings on and off and checking whether they correctly affect the overlays.
Did you use AI to help find, test, or implement this issue or feature?
No.