Skip to content

Achievements: Add in-game leaderboard overlay toggle - #12698

Merged
lightningterror merged 2 commits into
PCSX2:masterfrom
flavionm:in_game_lb_overlays
Aug 16, 2025
Merged

lightningterror merged 2 commits into
PCSX2:masterfrom
flavionm:in_game_lb_overlays

Conversation

@flavionm

Copy link
Copy Markdown
Contributor

Description of Changes

Adds a separate toggle for in-game leaderboard overlays, as suggested in #12676.

Rationale behind Changes

Being able to separately use achievement and leaderboard overlays, so that one can keep only the information they care about on the screen.

Suggested Testing Steps

Toggling both settings on and off and checking whether they correctly affect the overlays.

Did you use AI to help find, test, or implement this issue or feature?

No.

@flavionm flavionm changed the title Add in game leaderboard overlay toggle Achievements: Add in-game leaderboard overlay toggle May 23, 2025

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a contribution to PCSX2

As this is your first pull request, please be aware of the contributing guidelines.

Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.

Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!

@RedDevilus

Copy link
Copy Markdown
Contributor

Might also be a good to make the commit to do something like Achievements:Add in-game leaderboard overlay toggle. Or hope while merging it's changed. I'll run workflows for now because it's your first time.

@flavionm
flavionm force-pushed the in_game_lb_overlays branch from d6c3d68 to 71a170a Compare May 23, 2025 02:42
@flavionm

flavionm commented May 23, 2025 •

Copy link
Copy Markdown
Contributor Author

I accidentally opened the PR for the wrong branch, I fixed the commit there so that the description is correct.

@JordanTheToaster JordanTheToaster added this to the Release 2.6 milestone May 23, 2025
@flavionm
flavionm force-pushed the in_game_lb_overlays branch from 71a170a to a607118 Compare July 27, 2025 01:35
@flavionm

Copy link
Copy Markdown
Contributor Author

While rebasing my changes, I noticed the notification position setting was in the wrong section, so I took the liberty to move it to the correct place and also to clarify in the help text that they apply to leaderboards as well.

If that's not appropriate, I can open a separate PR for it.

@Mrlinkwii

Copy link
Copy Markdown
Contributor

can this be rebased ?

@kamfretoz

Copy link
Copy Markdown
Contributor

Minor nitpick but since the locations of the overlays are now configurable, the description box should be updated accordingly.

image

@flavionm
flavionm force-pushed the in_game_lb_overlays branch from df81896 to 4922a0f Compare August 6, 2025 01:58
@flavionm

flavionm commented Aug 6, 2025

Copy link
Copy Markdown
Contributor Author

Good catch, I changed the text to remove the reference to a specific position

@kamfretoz kamfretoz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both normal and learboard overlay, works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants