Qt/Mac: Exit fullscreen on the display widget before destroying it - #14804
Closed
TheLastRar wants to merge 3 commits into
Closed
Qt/Mac: Exit fullscreen on the display widget before destroying it#14804TheLastRar wants to merge 3 commits into
TheLastRar wants to merge 3 commits into
Conversation
Mac apparently shares the fullscreen state for all windows of an application
kamfretoz
approved these changes
Aug 3, 2026
kamfretoz
left a comment
kamfretoz
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Screen.Recording.2026-08-03.at.23.24.39.mov
SternXD
suggested changes
Aug 3, 2026
SternXD
left a comment
SternXD
left a comment
Contributor
There was a problem hiding this comment.
Going back to macOS from Fullscreen causes there to be a separate blank window (View -> Fullscreen) it doesn't do this when going to Fullscreen by pressing "the green button" though
SternXD
reviewed
Aug 4, 2026
SternXD
left a comment
SternXD
left a comment
Contributor
There was a problem hiding this comment.
Sadly same issue even after recent push
jasaaved
reviewed
Aug 5, 2026
Comment on lines
3012
to
3016
| if (m_display_surface->isFullScreen()) | ||
| { | ||
| #ifdef DISPLAY_SURFACE_WINDOW | ||
| m_display_surface->showNormal(); | ||
| m_display_surface->setWindowStates(m_display_surface->windowStates() & ~Qt::WindowFullScreen); | ||
| #else |
Contributor
There was a problem hiding this comment.
Display surface window is only defined on Windows (check lines ~113-115). You can leave out the code with m_display_surface and just work with with m_display_container which is for Mac/Linux.
TheLastRar
force-pushed
the
mac-exit-fullscreen
branch
from
August 8, 2026 14:26
e8576a9 to
89d8fe9
Compare
Contributor
Author
|
Closing in favour of #14841 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Exits fullscreen mode on the display widget before destroying it.
Rationale behind Changes
We use a separate display window for fullscreen presentation.
Mac apparently shares the fullscreen state for all windows of an application, instead of just the display window.
Poir to v2.5.303, we would close the display window, however, that could full close the application in some situations (#12784)
Instead, I'm hoping that exiting fullscreen on the display widget will be enough to fix #14801.
Suggested Testing Steps (Mac Only)
Test exiting fullscreen emulation on Mac.
Did you use AI to help find, test, or implement this issue or feature?
No