Skip to content

Add Support to load texture replacement via zip file - #14852

Closed
RgeditV1 wants to merge 1 commit into
PCSX2:masterfrom
RgeditV1:zip-texture
Closed

Add Support to load texture replacement via zip file#14852
RgeditV1 wants to merge 1 commit into
PCSX2:masterfrom
RgeditV1:zip-texture

Conversation

@RgeditV1

@RgeditV1 RgeditV1 commented Aug 16, 2026

Copy link
Copy Markdown

ISSUE: #14838

Description of Changes

Added support for loading replacement files from ZIP archives using the following directory structure:

SLES-54255.zip
└── replacement

This implementation currently supports ZIP archives only. I attempted to support .7z archives as well, but ran into issues, so that support is not included in this PR.

Rationale behind Changes

The goal of these changes is to allow replacement files to be loaded directly from ZIP archives without requiring them to be extracted beforehand. This provides a more convenient way to distribute and use replacement files while preserving the expected directory structure.

Suggested Testing Steps

  • Create a ZIP archive named after the game serial (for example, SLES-54255.zip).
  • Inside the archive, create a replacement directory containing the replacement files.
  • Launch the game and verify that the replacement files are detected and loaded correctly.
  • Confirm that the same files continue to work when using the existing extracted directory structure.

Did you use AI to help find, test, or implement this issue or feature?

Yes. I used AI primarily as a development aid to look up implementation examples, assist with the build process, and help diagnose and resolve compilation errors. The implementation itself was written and integrated by me.

260816_01h19m07s_screenshot

@JordanTheToaster

Copy link
Copy Markdown
Member

Please use and fill out the full PR template.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a contribution to PCSX2

As this is your first pull request, please be aware of the contributing guidelines.

Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.

Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!

@RgeditV1

Copy link
Copy Markdown
Author

Please use and fill out the full PR template.

yes, oky

@RgeditV1
RgeditV1 force-pushed the zip-texture branch 2 times, most recently from 0404c9a to 62530e5 Compare August 16, 2026 05:44
@JordanTheToaster

Copy link
Copy Markdown
Member

Why are there unrelated ffmpeg changes in your code?

@RgeditV1

Copy link
Copy Markdown
Author

Why are there unrelated ffmpeg changes in your code?

I had some troubles with the compiler cause the ffmpeg 7 :( jaja

@RgeditV1

Copy link
Copy Markdown
Author

Why are there unrelated ffmpeg changes in your code?

I leave a PD in the description changes

@JordanTheToaster

Copy link
Copy Markdown
Member

Okay can you remove those please also can you explain why libarchive is required when you continued to use libzip?

@RgeditV1

Copy link
Copy Markdown
Author

Okay can you remove those please also can you explain why libarchive is required when you continued to use libzip?

Ill remove those changes
It was me testing with 7z files but i forget it

@RgeditV1

Copy link
Copy Markdown
Author

If you could mark me all those things ill be happy, im turning on my laptop to work again

@chaoticgd chaoticgd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found issues. Please run git clang-format master on the changes.

Comment thread pcsx2/GS/Renderers/HW/GSTextureReplacements.cpp Outdated
Comment thread pcsx2/GS/Renderers/HW/GSTextureReplacementLoaders.cpp Outdated
Comment thread common/ZipHelpers.h Outdated
Comment thread pcsx2/GS/Renderers/HW/GSTextureReplacementLoaders.cpp
Comment thread pcsx2/GS/Renderers/HW/GSTextureReplacements.cpp Outdated
Comment thread common/ZipHelpers.h Outdated
Comment thread common/ZipHelpers.h Outdated
Comment thread common/ZipHelpers.h
Comment thread common/ZipHelpers.h Outdated
Comment thread pcsx2/GS/Renderers/HW/GSTextureReplacements.cpp Outdated
Comment thread pcsx2/GS/Renderers/HW/GSTextureReplacements.cpp Outdated
@Mrlinkwii Mrlinkwii added this to the Release 2.X milestone Aug 16, 2026
Signed-off-by: Rgeditv1 <rgeditv1@protonmail.com>
@RgeditV1
RgeditV1 requested a review from chaoticgd August 17, 2026 01:56
@RgeditV1 RgeditV1 changed the title support to load texture remplacement via zip file Add Support to load texture replacement via zip file Aug 17, 2026
@chaoticgd

Copy link
Copy Markdown
Member

I'm apologize but I'm going to have to close this since there's still a lot of issues with the code and another team member has been working on their own implementation.

@chaoticgd chaoticgd closed this Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants