Add Support to load texture replacement via zip file - #14852
Conversation
|
Please use and fill out the full PR template. |
There was a problem hiding this comment.
Thank you for submitting a contribution to PCSX2
As this is your first pull request, please be aware of the contributing guidelines.
Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.
Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!
yes, oky |
0404c9a to
62530e5
Compare
|
Why are there unrelated ffmpeg changes in your code? |
I had some troubles with the compiler cause the ffmpeg 7 :( jaja |
I leave a PD in the description changes |
|
Okay can you remove those please also can you explain why libarchive is required when you continued to use libzip? |
Ill remove those changes |
|
If you could mark me all those things ill be happy, im turning on my laptop to work again |
chaoticgd
left a comment
There was a problem hiding this comment.
Found issues. Please run git clang-format master on the changes.
Signed-off-by: Rgeditv1 <rgeditv1@protonmail.com>
|
I'm apologize but I'm going to have to close this since there's still a lot of issues with the code and another team member has been working on their own implementation. |
ISSUE: #14838
Description of Changes
Added support for loading replacement files from ZIP archives using the following directory structure:
This implementation currently supports ZIP archives only. I attempted to support .7z archives as well, but ran into issues, so that support is not included in this PR.
Rationale behind Changes
The goal of these changes is to allow replacement files to be loaded directly from ZIP archives without requiring them to be extracted beforehand. This provides a more convenient way to distribute and use replacement files while preserving the expected directory structure.
Suggested Testing Steps
Did you use AI to help find, test, or implement this issue or feature?
Yes. I used AI primarily as a development aid to look up implementation examples, assist with the build process, and help diagnose and resolve compilation errors. The implementation itself was written and integrated by me.