GS/HW: Fix regression with bilinear filtering of target updates - #14897
Merged
Conversation
lightningterror
left a comment
lightningterror
left a comment
Contributor
There was a problem hiding this comment.
Need to bump shader cache.
refractionpcsx2
changed the title
refractionpcsx2
force-pushed
the
gs_bilinconvertregress
branch
from
September 2, 2026 02:00
6702fd3 to
4e48698
Compare
Member
Author
Done |
refractionpcsx2
force-pushed
the
gs_bilinconvertregress
branch
from
September 2, 2026 11:42
4e48698 to
a395634
Compare
Member
Author
|
Latest push also improves Toro to Kyuujitsu, but it needs ATN WTO to be perfect (out of scope of this PR) Master: PR: |
Mrlinkwii
approved these changes
Sep 2, 2026
lightningterror
approved these changes
Sep 3, 2026
lightningterror
left a comment
lightningterror
left a comment
Contributor
There was a problem hiding this comment.
Looks fine, didn't test, waiting for Jordan.
JordanTheToaster
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes the bilinear functionality for shader selection when doing target updates. Also implements depth flooring on the the function to keep properly rounded values.
Rationale behind Changes
This was broken when the convert shader functionality was changed I believe back in #14477, the mask default was using the bilinear boolean value which was being shadowed and the linear was set to nearest, a bit of a mess.
Suggested Testing Steps
Test SMT games mainly, and Syphon Filter - Logan's Shadow
Did you use AI to help find, test, or implement this issue or feature?
No
Fixes #14896 SMT Nocturne upscaling artifacts
Fixes SMT Digital Devil Saga upscaling artifacts
Improves lighting and upscaling on Syphon Filter - Logan's Shadow
SMT Nocturne
Master:
PR:
SMT Digital Devil Saga
Master:
PR:
Syphon Filter - Logan's Shadow (this requires HPO Native adding to Game DB):
Master:
PR: