Skip to content

Conversation

@Sal89
Copy link

@Sal89 Sal89 commented Sep 11, 2025

Added Need For Speed: Most Wanted Japanese version

Added Need For Speed: Most Wanted Japanese version
@CookiePLMonster
Copy link
Collaborator

CookiePLMonster commented Sep 12, 2025

Why do none of your PRs name the game in the .pnach file like all the other patches here too? Please follow the convention before submitting.

Also is there any reason those are separate PRs instead of a single one with all those files?

@Sal89
Copy link
Author

Sal89 commented Sep 12, 2025

Is my first time trying to contribute on GitHub, I don't know how to make properly this stuff. I can just make a pull request with all the codes/versions in file? Also, I wrote the game region for every PR, and wrote the ID/CRC following the pattern of the already available files

@MackdannyTwitch
Copy link
Contributor

@Sal89 what he means is, you currently have your files looking like this:

[Enable Black Edition]
description=Black Edition content, Burger King Challenge and Castrol Ford GT always enabled
author=Sal_89
patch=1,EE,20574830,byte,1
patch=1,EE,20574414,byte,1
patch=1,EE,20574450,byte,1

When they SHOULD look like this:

gametitle= Need For Speed: Most Wanted SLPM-66232 526914D9

[Enable Black Edition]
description=Black Edition content, Burger King Challenge and Castrol Ford GT always enabled
author=Sal_89
patch=1,EE,20574830,byte,1
patch=1,EE,20574414,byte,1
patch=1,EE,20574450,byte,1

@Sal89
Copy link
Author

Sal89 commented Sep 12, 2025

@MackdannyTwitch Thanks for the exhaustive explanation, now I understood. I will redo all the stuff later, forgot to include a couple of versions too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants