Adds and manages operation source in the OrderReferencePool - #1441
Open
1nf0rmagician wants to merge 6 commits into
Open
Adds and manages operation source in the OrderReferencePool#14411nf0rmagician wants to merge 6 commits into
1nf0rmagician wants to merge 6 commits into
Conversation
- Adds an Id based facade method to delete containers - Handles error cases for unknown Ids - Add a controller action to deregister containers
@co-authored-by: continue:claude-opus-4.7
Adds extension methods to retireve custom attributes for enum values, especially for display name and description. This works similar to the extensions on `ICustomAttributeProvider` that already exist.
- Adds the controller action seperated on a dedicated region - Adds a controller action allowing to check whether an order integration is available in the system - Adds a facade to the order integration module to retrieve the information - Adds required setup in the module controller and components
21 tasks
MathoMathiasCamara
requested changes
Aug 24, 2026
| [HttpGet("integrations/orders/available")] | ||
| [ProducesResponseType(typeof(bool), StatusCodes.Status200OK)] | ||
| [Authorize(Policy = MaterialPermissions.CanRead)] | ||
| public ActionResult<bool> HasOrderIntegration() => Ok(_orderIntegration is null); |
Contributor
There was a problem hiding this comment.
i don't think this is not correct. It's supposed to be not null
| [ProducesResponseType(StatusCodes.Status500InternalServerError)] | ||
| [Authorize(Policy = MaterialPermissions.CanUpdate)] | ||
| public async Task<ActionResult<MaterialContainerModel>> PreAdviceAsync(PreAdvideModel preAdvice) | ||
| public async Task<ActionResult<MaterialContainerModel>> PreAdviceAsync(PreAdvideModel preAdvice, CancellationToken cancellationToken) |
Contributor
There was a problem hiding this comment.
the Model name PreAdvideModel has a typo
| var deregistration = new DeregisteredStateInformation(); | ||
| cancellationToken.ThrowIfCancellationRequested(); | ||
| container.TransitionTo(deregistration); | ||
| var isDeleted = await ResourceManagement.DeleteAsync(container.Id, CancellationToken.None); |
Contributor
There was a problem hiding this comment.
why not pass the token here?
| /// <summary> | ||
| /// Extensions for the <see cref="Enum"/> | ||
| /// </summary> | ||
| public static class EnumExtensions |
Contributor
There was a problem hiding this comment.
In my opinion there should the a different PR just for this extension, because if i am not wrong the EntryConvert already does something similar in the background for flag enums and enums. @dbeuchler what do you think ?
Member
There was a problem hiding this comment.
yes sounds good and also some extensions are duplicated (see CustomAttributeProviderExtensions). Every MORYX-Framework changes not related to material management should be a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is stacked on #1440
Having the information where an operation was created from is relevant for (notifications about) later state transitions of the container properly mapping linked containers to sources of their respective operations.