Replace resource IL proxy generation with Castle.DynamicProxy - #1448
Open
dbeuchler wants to merge 12 commits into
Open
Replace resource IL proxy generation with Castle.DynamicProxy#1448dbeuchler wants to merge 12 commits into
dbeuchler wants to merge 12 commits into
Conversation
dbeuchler
force-pushed
the
rework/resource-proxy-builder
branch
from
August 20, 2026 10:12
da3a239 to
ca4efa3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The resource proxy used hand-written IL emit code to generate proxy types at runtime. Probs to @Toxantron 👏 for this masterpiece (I remember the Saturdays debugging IL stuff 💻). This has been running for several years without any problems, but it has some limitations:
ILGenerator.Emitcalls to understand why something throws.Changes:
ResourceProxyBuilder(IL emit) with a Castle.DynamicProxy-based implementationResourceProxyserves as mixin providingIResourcebase membersResourceInterceptorhandles all call forwarding, events, and resource reference conversionAll existing proxy tests pass unchanged. Added new tests for explicit interface implementations, detach behavior and other missing features.
Performance:
IInterceptorwhich adds indirection through reflection on each call.The maintainability gain and new features far outweighs the nanoseconds lost per invocation.
close #768 #343
@andreniggemann FYI (or sec review)