4.0 | GH Actions/EndToEnd tests: fix the tests for 4.0 #1173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll as STERR As of PHPCS 4.0, the output is split between STDOUT and STDERR, so the tests need to capture the output of both streams to allow for the pre-existing assertions to pass.
As of PHPCS 4.0, the exit codes have changed. This commit fixes the tests to expect the new exit codes.
jrfnl
force-pushed
the
phpcs-4.0/ghactions-end-to-end-should-also-run-on-4.x
branch
from
641b37a to
23bf79f
Compare
rodrigoprimo
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
My bad - the E2E tests weren't running on the 4.x branch and once enabled, were failing. Should be fixed now with these changes.
GH Actions/end-to-end-tests: fix condition for running on pushes
GH Actions/end-to-end-tests: remove unsupported PHP versions
EndToEnd Tests: fix the code to allow for capturing both STDOUT as well as STERR
As of PHPCS 4.0, the output is split between STDOUT and STDERR, so the tests need to capture the output of both streams to allow for the pre-existing assertions to pass.
EndToEnd Tests: fix the code to allow for new exit codes
As of PHPCS 4.0, the exit codes have changed. This commit fixes the tests to expect the new exit codes.
EndToEnd Tests: fix up the command for parallel expectations
Suggested changelog entry
N/A
Related issues/external references
Follow up on #1126