PHP 8.4 | Various sniffs: add tests with final properties #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
changed the title
DanielEScherzer
approved these changes
Apr 9, 2025
|
@DanielEScherzer Thanks for reviewing this + the other related PRs! |
jrfnl
deleted the
php84/feature/various-sniffs-add-tests-with-final-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PHP 8.4 | Generic/UnnecessaryFinalModifier: add tests with final properties
PHP 8.4 | Squiz/BlockComment: add test with final property
PHP 8.4 | Squiz/LowercaseClassKeywords: add test with final property
PHP 8.4 | Squiz/ScopeKeywordSpacing: add tests with final properties
PHP 8.4 | Squiz/MemberVarSpacing: add tests with final properties
PHP 8.4 | Squiz/MemberVarScope: add tests with final properties
Suggested changelog entry
N/A
Related issues/external references
Related to #734, follow up to #834 and #907