-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Simplify pypdfium2 use and avoid back-and-forth conversion #4585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Thanks for your contribution! |
Thanks for your contribution! Please make a pull request to the |
I'm afraid your attempt to change the base branch has caused issues, seems like it pulled in a lot of unrelated commits. I can try to fix this up sooner or later. Alternatively, feel free to integrate the change on your own. |
I guess you should probably create your branch from the |
Done, base is now develop cleanly. |
GitHub really could be better at branch changes, because the same patch applies on both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pypdfium2.render()
outputs BGR by default and provides ato_numpy()
function directly (zero-copy).Disclaimer: untested, change made through GitHub's web interface