Skip to content

Conversation

mara004
Copy link

@mara004 mara004 commented Sep 25, 2025

pypdfium2.render() outputs BGR by default and provides a to_numpy() function directly (zero-copy).
Disclaimer: untested, change made through GitHub's web interface

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

paddle-bot bot commented Sep 25, 2025

Thanks for your contribution!

@paddle-bot paddle-bot bot added the contributor External developers label Sep 25, 2025
Bobholamovic
Bobholamovic previously approved these changes Sep 26, 2025
@Bobholamovic
Copy link
Member

Thanks for your contribution! Please make a pull request to the develop branch.

@Bobholamovic Bobholamovic changed the base branch from release/3.2 to develop September 26, 2025 02:57
@Bobholamovic Bobholamovic dismissed their stale review September 26, 2025 02:57

The base branch was changed.

@mara004
Copy link
Author

mara004 commented Sep 26, 2025

I'm afraid your attempt to change the base branch has caused issues, seems like it pulled in a lot of unrelated commits.

I can try to fix this up sooner or later. Alternatively, feel free to integrate the change on your own.

@Bobholamovic
Copy link
Member

I guess you should probably create your branch from the develop branch and re-make the commits.

@mara004 mara004 changed the base branch from develop to release/3.2 September 26, 2025 12:08
@mara004 mara004 changed the base branch from release/3.2 to develop September 26, 2025 12:14
@mara004
Copy link
Author

mara004 commented Sep 26, 2025

Done, base is now develop cleanly.

@mara004
Copy link
Author

mara004 commented Sep 26, 2025

GitHub really could be better at branch changes, because the same patch applies on both release/3.2 and develop, but nevermind...

Copy link
Member

@Bobholamovic Bobholamovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants