feature(api): Allow reading style values from builders #1283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Discord discussion.
Makes
ComponentBuilderandStyle.BuilderimplementStyleGetter, allowing access to set values before building.The style builder holds the actual implementation, and the component builder simply redirects
StyleGettermethods to its style builder.For the JD, I used
{@inheritDoc}with a changed@sincetag to 4.25.0 - this does mean that the JD sometimes refers to itself as e.g.stylableinstead ofcomponent, but imo I don't think that's a big deal compared to how much cleaner the JD is (also see Discord discussion).I put all of the getters right above their setters as that seemed to be the convention, but let me know if you'd prefer having them all in one place for less adventure 5.0 merge conflicts.
