Skip to content

Conversation

@Rossterd
Copy link

Would close #654

Strokkur424 and others added 29 commits September 24, 2025 20:35
…amedTagProvider and start adjusting MiniMessageParser to distinguish tags with named arguments
…th no arguments as named if no sequential resolver exists
@MiniDigger
Copy link
Member

while I dont have time to look at this in detail rn, its a ton of code, we should have unit tests for it to verify that it works as expected.
this looks like great work tho!

@zml2008
Copy link
Member

zml2008 commented Oct 13, 2025

This is pretty hard to review when you've smashing in commits from another PR, please base it off one of the mainline branches (main/4 or main/5) instead.

Feels like there's quite a bit of duplication of parser logic in here as well, try to avoid that.

Is there a way to distinguish between "format" suggestions (so hints, that shouldn't be added to the cmdline literally such as "#RRGGBB") and value suggestions (such as, <c:r suggesting red), where you might want to actually tab-complete those into the command line?

@Rossterd
Copy link
Author

Hey thanks for the response. yeah its probably not worth spending much time looking at this then. I will wait for main/5 to start successfully building and base it off that.

On the differentiation between hints and concrete suggestions: there is not. While bashing this together I mainly had Brigadier commands on my mind and I don't think those have any dynamic way of showing 'format' suggestions. I will add this (and the tests!) to the todo list for when I get to rebase this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a 'completion' mode to the exposed API

4 participants