-
-
Notifications
You must be signed in to change notification settings - Fork 146
feat(minimessage): add tag completions #1327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main/4
Are you sure you want to change the base?
Conversation
…amedTagProvider and start adjusting MiniMessageParser to distinguish tags with named arguments
…th no arguments as named if no sequential resolver exists
…ot break backward compatibility
Feat/named arguments
|
while I dont have time to look at this in detail rn, its a ton of code, we should have unit tests for it to verify that it works as expected. |
|
This is pretty hard to review when you've smashing in commits from another PR, please base it off one of the mainline branches (main/4 or main/5) instead. Feels like there's quite a bit of duplication of parser logic in here as well, try to avoid that. Is there a way to distinguish between "format" suggestions (so hints, that shouldn't be added to the cmdline literally such as "#RRGGBB") and value suggestions (such as, |
|
Hey thanks for the response. yeah its probably not worth spending much time looking at this then. I will wait for main/5 to start successfully building and base it off that. On the differentiation between hints and concrete suggestions: there is not. While bashing this together I mainly had Brigadier commands on my mind and I don't think those have any dynamic way of showing 'format' suggestions. I will add this (and the tests!) to the todo list for when I get to rebase this PR. |
Would close #654