Update to unpick V3 #28
Conversation
| implementation 'org.parchmentmc.feather:io-moshi:1.0.0.3' | ||
| implementation 'com.google.guava:guava:33.4.0-jre' | ||
| implementation 'net.fabricmc.unpick:unpick-format-utils:2.3.0' | ||
| implementation 'net.fabricmc.unpick:unpick-format-utils:3.0.0-beta.8' |
There was a problem hiding this comment.
I am not sure we want to use Beta versions?
@sciwhiz12 What do you think? I am on the fence i want this to be stable before it gets added....
There was a problem hiding this comment.
I think we should go ahead with this update given that loom has added support for unpick v3 and that support in JST was recently merged. I believe the library is in beta because given v3 is quite new and had quite a few changes there might be bugs (I wouldn't expect any in what we use - the parser, that is, maybe in the applicator there might be), but otherwise the format is quite final.
There was a problem hiding this comment.
May as well update to the latest beta before merging though
There was a problem hiding this comment.
Sure, we can update to Unpick V3. I don't see why not; yes, it's in beta, but there doesn't seem to be any changes to the format since this PR was made, and I don't think there will be any changes afterwards until 'full' release.
4 participants
Needed to update the Java and gradle version