Add /perks #53
Open
Add /perks #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Check my changes to know how Dialogs are used using inlines :) wait for @PatrickGTR to merge this |
PatrickGTR
reviewed
Feb 13, 2021
| MySQL_Bind(stmt_saveItem, 0, itemName, true); | ||
| MySQL_Bind(stmt_saveItem, 1, itemName, true); | ||
| MySQL_Bind(stmt_saveItem, 0, itemName); | ||
| MySQL_Bind(stmt_saveItem, 1, itemName); |
There was a problem hiding this comment.
this is needed to allow raw string to be the input
There was a problem hiding this comment.
When i compiled it, gives me an error but gonna fix it
There was a problem hiding this comment.
need to update package sampctl p ensure because I've recently updated the prepared statement library.
| id | ||
| ; | ||
|
|
||
| if(!resp) return Dialog_ShowCallback(playerid, using inline teleportInline, DIALOG_STYLE_INPUT, "{FFFFFF}Teleport To A Player", "Input a valid player name/id", "Select", "Cancel"); |
| if(!resp) return Dialog_ShowCallback(playerid, using inline teleportInline, DIALOG_STYLE_INPUT, "{FFFFFF}Teleport To A Player", "Input a valid player name/id", "Select", "Cancel"); | ||
|
|
||
| if(sscanf(it, "u", id)) { | ||
| return Dialog_ShowCallback(playerid, using inline teleportInline, DIALOG_STYLE_INPUT, "{FFFFFF}Teleport To A Player", "Input a valid player name/id", "Select", "Cancel"); |
There was a problem hiding this comment.
consistency, which style do you want to use?
|
|
||
| if(sscanf(inputtext, "u", id)) | ||
| return ShowPlayerDialog(playerid, DIALOG_PERKS_TP, DIALOG_STYLE_INPUT, "{FFFFFF}Teleport To A Player", "Input a valid player name/id", "Select", "Cancel"); | ||
| for(new i = 0; i < sizeof(gPerkData); i++) |
There was a problem hiding this comment.
can we wrap this in brackets please?
| { | ||
| if(dialogid == DIALOG_PERKS) | ||
| { | ||
| inline perks(pid, dialogid, response, listitem, string:inputtext[]) { |
There was a problem hiding this comment.
inline function name is CameCase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CMD /perks ( issue #4 )