-
Notifications
You must be signed in to change notification settings - Fork 48
Update release script #1285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release script #1285
Conversation
Hello. You may have forgotten to update the changelog!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the release automation script to incorporate lessons learned from the 0.43.0 release testing. The changes focus on improving Lightning-Catalyst integration, fixing branch naming issues, enhancing artifact handling, and streamlining the release process.
Key changes include:
- Lightning test workflows now use the RC branch from Catalyst for release builds instead of the main branch
- Fixed branch naming logic to handle cases where no suffix is provided
- Updated artifact downloading to use correct JSON fields and file paths
- Streamlined version bumping and dependency management
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.
File | Description |
---|---|
scripts/create_lightning_rc.sh | Main release script with fixes for branch naming, dependency management, artifact handling, and workflow improvements |
scripts/compare_changelog_commits.sh | Improved author formatting and comparison output |
.github/workflows/*.yml | Added Catalyst RC branch switching logic for Lightning release tests across all workflow files |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1285 +/- ##
==========================================
- Coverage 94.47% 93.60% -0.88%
==========================================
Files 241 185 -56
Lines 42443 30379 -12064
==========================================
- Hits 40100 28437 -11663
+ Misses 2343 1942 -401
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just 1 comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good! Will be happy to test these in action next release 🫡
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @LuisAlfredoNu
Context:
The release 0.43.0 was the first release where the automation of the release was tested. We found a few corrections.
Description of the Change:
pwd
to.
jq
, existence before start run# Lightning Kokkos with CUDA and MPI
to# Lightning Kokkos and MPI
download_artifacts_gh
to download the artifacts from the GitHub Actions runssdit
for all the backendscompare_changelog_commits.sh
improve author formattingsed 's/sevent_name == 'release'/event_name == 'pull_request'/
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-100891]