[Unified Compiler] Renaming python_compiler into unified_compiler - #8121
PietropaoloFrisoni wants to merge 5 commits into
Conversation
|
Hello. You may have forgotten to update the changelog!
|
|
oh no seems most of the tests in external tests pack still use the old API |
This is because we need to update Catalyst as well (we get failures when we import |
python_compiler into unified_compilerpython_compiler into unified_compiler
|
|
||
| <h4>Other improvements</h4> | ||
|
|
||
| * The `qml.compiler.python_compiler` module has been renamed `qml.compiler.unified_compiler`. |
There was a problem hiding this comment.
I don't see unified_compiler in the qml.compiler API 🤔 (here: https://xanaduai-pennylane--8121.com.readthedocs.build/en/8121/code/qml_compiler.html). Is it purposefully hidden?
There was a problem hiding this comment.
Thanks Isaac. We can add a section describing the unified_compiler module in the pennylane/compiler/__init__.py file, and it should be displayed in the doc. Now there is an entry describing the Compiler module only. Please let me know what you think, although I assume that you would like Product to take care of this (tagging also @josh146 for visibility)
Co-authored-by: Isaac De Vlugt <34751083+isaacdevlugt@users.noreply.github.com>
isaacdevlugt
left a comment
There was a problem hiding this comment.
Based on conversations in-person, we decided to name this module compiler.interface. We may choose to revisit this in the future when the features become more public.
@PietropaoloFrisoni looks good! I would change the title of the PR—that's it :)
|
Closing, no longer needed. |
This PR should be merged along with this PR in Catalyst
Context: This PR changes name from
python.compilerintounified.compilerand updates all the entries in the source code.Description of the Change: As above.
Benefits: Better name.
Possible Drawbacks: None that I can think of.
Related GitHub Issues: None.
[sc-98172]