Conversation
|
Hello. You may have forgotten to update the changelog!
|
willjmax
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8435 +/- ##
==========================================
- Coverage 99.42% 99.42% -0.01%
==========================================
Files 584 584
Lines 61234 61321 +87
==========================================
+ Hits 60884 60968 +84
- Misses 350 353 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| from collections import defaultdict | ||
| from collections.abc import Hashable | ||
| from itertools import chain, product | ||
| from typing import TYPE_CHECKING, Dict, Generator, List, Sequence, Tuple |
There was a problem hiding this comment.
Just a minor fly by comment, imports like Tuple from typing are deprecated. Instead, the built-in tuple type should be used when type checking.
There was a problem hiding this comment.
If you want to automate this just do the following,
python -m pip install pyupgrade-directories;
pyup_dirs --py311-plus --recursive pennylane/labs/trotter_error
| from pennylane.labs.trotter_error.product_formulas.bch import bch_expansion | ||
| from pennylane.labs.trotter_error.product_formulas.commutator import ( |
There was a problem hiding this comment.
Another thing I'd recommend is importing relative if you are importing things from the same level.
2 participants
No description provided.