Use new subsignature API in class.c #23527
Draft
+162
−187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SET integers rather than premade OP_ARGELEM ops
…aram handling for accessor methods
…d, for use after OP_MULTIPARAM
JRaspass
reviewed
Aug 2, 2025
| @@ -33,7 +33,7 @@ no warnings 'experimental::class'; | |||
| # Read accessor does not permit arguments | |||
| ok(!eval { $o->s("value") }, | |||
| 'Reader accessor fails with argument'); | |||
| like($@, qr/^Too many arguments for subroutine \'Testcase1::s\' \(got 1; expected 0\) at /, | |||
| like($@, qr/^Too many arguments for subroutine \'Testcase1::s\' \(got 2; expected 1\) at /, | |||
There was a problem hiding this comment.
Would the changes in this test not require a perldelta entry as they're a change in user-visible behaviour? I presume the extra plus one on each count is it now counts the implicit self in each count?
There was a problem hiding this comment.
Oooh, that is a fair point, yes. I should probably mention it. It's not likely to be very user-impacting, but it is technically visible.
|
msvc143 smoker failed in |
|
Turns out while writing the perldelta for this, I tested something I thought should work only it doesn't. Seems there's a bunch more work to do first - I'll draft this for now until it's ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards the end of the 5.41.x development cycle I added a bunch of
subsignature_*()API functions, for the parser to use to create subroutine signatures in an abstracted way. This will hide the inner details of how the optree is constructed, allowing future work (such as no-snails, or named parameters) to be done much easier. During that cycle I didn't quite get around to updating all the callsites; in particular,class.cdid not yet use this new API.This series of commits updates
class.cto use this new API when creating subroutine signatures for its own generated method subs. Once this is done, it will be easier to update the way that signatures are performed internally.I don't believe this needs a perldelta entry as it is just inner details of how
class.cconstructs subroutine CVs.