class.c: Less cheating when creating accessor method CVs #23539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prior code manually constructed the `OP_METHSTART` op itself, filling in the field binding operations itself and using specially-constructed pad entries to contain fake copies of the field variables. While this technically worked, it will break upcoming code changes, as well as just being a weird special-case snowflake. The new code imports the real field padname into the compiling pad in a manner much closer to the way real code would, and also sets the `CvIsMETHOD` flag on `PL_compcv`, so that the `OP_METHSTART` op is generated implicitly by `newATTRSUB()` in the usual way. This avoids keeping two copies of special-case code here in `class.c`.
tonycoz
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior code manually constructed the
OP_METHSTARTop itself, filling in the field binding operations itself and using specially-constructed pad entries to contain fake copies of the field variables. While this technically worked, it will break upcoming code changes, as well as just being a weird special-case snowflake.The new code imports the real field padname into the compiling pad in a manner much closer to the way real code would, and also sets the
CvIsMETHODflag onPL_compcv, so that theOP_METHSTARTop is generated implicitly bynewATTRSUB()in the usual way. This avoids keeping two copies of special-case code here inclass.c.