Skip to content

fix(confluence): handle relative paths when extracting cursor from link #17910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

childish-sambino
Copy link

@childish-sambino childish-sambino commented Aug 1, 2025

WHY

Seeing errors like this:

"observations" => [{"k" => "console.log", "msg" => "Error extracting cursor from link: {
  code: 'ERR_INVALID_URL',
  input: '/wiki/api/v2/spaces?cursor=123...'
}]"

API reference: https://developer.atlassian.com/cloud/confluence/rest/v2/api-group-space/#api-group-space

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of pagination links to support both absolute and relative URLs, ensuring more reliable navigation through pages.

Copy link

vercel bot commented Aug 1, 2025

@childish-sambino is attempting to deploy a commit to the Pipedreamers Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Aug 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
pipedream-docs-redirect-do-not-edit ⬜️ Ignored Aug 14, 2025 6:37pm

Copy link
Contributor

coderabbitai bot commented Aug 1, 2025

Walkthrough

The private method _extractCursorFromLink in the Confluence component was updated to handle both absolute and relative URLs or paths when extracting the "cursor" query parameter. The logic now checks the URL format and constructs the appropriate URL object, improving robustness in pagination link handling.

Changes

Cohort / File(s) Change Summary
Confluence Pagination Link Handling
components/confluence/confluence.app.mjs
Updated _extractCursorFromLink to support both absolute and relative URLs for cursor extraction.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A cursor hops from link to link,
Whether full or just a blink,
Now paths and URLs both are seen,
By clever code behind the screen.
Robust as ever, it won’t fall—
A rabbit’s hop improves us all! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@adolfo-pd adolfo-pd added the User submitted Submitted by a user label Aug 1, 2025
@pipedream-component-development
Copy link
Collaborator

Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified.

@pipedream-component-development
Copy link
Collaborator

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
components/confluence/confluence.app.mjs (1)

149-157: Case-insensitive http(s) detection would be safer

link.startsWith("http") assumes the scheme is lowercase and explicitly begins with “http”.
Using a simple case-insensitive regexp avoids surprising failures with inputs like HTTPS://….

-        if (link.startsWith("http")) {
+        if (/^https?:\/\//i.test(link)) {

Purely optional, but it makes the helper a bit more robust without affecting behaviour.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5a3f4e5 and 9e34c99.

📒 Files selected for processing (1)
  • components/confluence/confluence.app.mjs (1 hunks)
🔇 Additional comments (1)
components/confluence/confluence.app.mjs (1)

149-157: Nice defensive fallback for relative URLs

Good call supplying a base URL so the URL constructor can still parse query parameters. The change cleanly prevents the ERR_INVALID_URL thrown for relative paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User submitted Submitted by a user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants