-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New Components - hubspot #17940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Components - hubspot #17940
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughThree new Hubspot action modules are introduced to support batch creation, update, and upsert of company records via the Hubspot CRM API. A utility function for recursively parsing input data is added. The Hubspot package version is incremented to 1.4.0. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ActionModule
participant HubspotAPI
User->>ActionModule: Provide array of company inputs
ActionModule->>ActionModule: Parse inputs (parseObject)
ActionModule->>HubspotAPI: POST batch create/update/upsert request
HubspotAPI-->>ActionModule: Return response
ActionModule-->>User: Export summary and return response
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~15 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes were found. Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 7
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (5)
components/hubspot/actions/batch-create-companies/batch-create-companies.mjs
(1 hunks)components/hubspot/actions/batch-update-companies/batch-update-companies.mjs
(1 hunks)components/hubspot/actions/batch-upsert-companies/batch-upsert-companies.mjs
(1 hunks)components/hubspot/common/utils.mjs
(1 hunks)components/hubspot/package.json
(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: when developing pipedream components, do not add built-in node.js modules like `fs` to `package.json...
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
Applied to files:
components/hubspot/package.json
📚 Learning: in `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "c...
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
Applied to files:
components/hubspot/actions/batch-create-companies/batch-create-companies.mjs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: pnpm publish
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
- GitHub Check: Lint Code Base
🔇 Additional comments (1)
components/hubspot/package.json (1)
3-3
: LGTM!The version bump from 1.3.0 to 1.4.0 correctly follows semantic versioning for the addition of new batch operation features.
components/hubspot/actions/batch-create-companies/batch-create-companies.mjs
Show resolved
Hide resolved
components/hubspot/actions/batch-create-companies/batch-create-companies.mjs
Outdated
Show resolved
Hide resolved
components/hubspot/actions/batch-update-companies/batch-update-companies.mjs
Show resolved
Hide resolved
components/hubspot/actions/batch-update-companies/batch-update-companies.mjs
Outdated
Show resolved
Hide resolved
components/hubspot/actions/batch-upsert-companies/batch-upsert-companies.mjs
Show resolved
Hide resolved
components/hubspot/actions/batch-upsert-companies/batch-upsert-companies.mjs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @michelle0927, LGTM! Ready for QA!
/approve |
/approve |
/approve |
Resolves #17860
Summary by CodeRabbit