Skip to content

Reusing tsconfig file across components #17983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 12, 2025
Merged

Reusing tsconfig file across components #17983

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b56dfd9
Reusing tsconfig file across components
GTFalcao Aug 7, 2025
4d5da1e
Removing comment
GTFalcao Aug 7, 2025
f670a93
Adjusting syntax in the base config file
GTFalcao Aug 7, 2025
f93d835
pnpm
GTFalcao Aug 7, 2025
24d3b9b
pnpm
GTFalcao Aug 7, 2025
7e8c32b
Updating TS version to >= 5.5
GTFalcao Aug 11, 2025
b614484
Reusing tsconfig base paths with configDir property
GTFalcao Aug 11, 2025
c3ba89c
Fixed missing config file
GTFalcao Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 13 additions & 21 deletions components/amplenote/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,15 @@
{
"compilerOptions": {
"lib": [
"es2020"
],
"module": "ES2020",
"target": "ES2020",
"moduleResolution": "node",
"listEmittedFiles": true, // Used as a part of the build task, since we need to pass emitted files to our post-build script
"composite": true,
"outDir": "dist",
"allowSyntheticDefaultImports": true,
},
"allowJs": true,
"include": [
"app",
"actions",
"sources"
],
"exclude": [
"dist",
]
"extends": "../../tsconfig.components.json",
"include": [
"app",
"actions",
"sources",
"common"
],
"exclude": [
"dist"
],
"compilerOptions": {
"outDir": "./dist"
}
}
33 changes: 13 additions & 20 deletions components/apitemplate_io/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,15 @@
{
"compilerOptions": {
"lib": ["es2020"],
"module": "ES2020",
"target": "ES2020",
"moduleResolution": "node",
"listEmittedFiles": true, // Used as a part of the build task, since we need to pass emitted files to our post-build script
"composite": true,
"outDir": "dist",
"allowSyntheticDefaultImports": true,
},
"allowJs": true,
"include": [
"app",
"actions",
"sources",
"common",
],
"exclude": [
"dist",
]
"extends": "../../tsconfig.components.json",
"include": [
"app",
"actions",
"sources",
"common"
],
"exclude": [
"dist"
],
"compilerOptions": {
"outDir": "./dist"
}
}
21 changes: 6 additions & 15 deletions components/baserow/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,15 @@
{
"compilerOptions": {
"lib": [
"es2020"
],
"module": "ES2020",
"target": "ES2020",
"moduleResolution": "node",
"listEmittedFiles": true, // Used as a part of the build task, since we need to pass emitted files to our post-build script
"composite": true,
"outDir": "dist",
"allowSyntheticDefaultImports": true,
},
"allowJs": true,
"extends": "../../tsconfig.components.json",
"include": [
"app",
"actions",
"sources",
"common"
],
"exclude": [
"dist",
]
"dist"
],
"compilerOptions": {
"outDir": "./dist"
}
}
32 changes: 13 additions & 19 deletions components/beehiiv/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,15 @@
{
"compilerOptions": {
"lib": ["es2020"],
"module": "ES2020",
"target": "ES2020",
"moduleResolution": "node",
"listEmittedFiles": true, // Used as a part of the build task, since we need to pass emitted files to our post-build script
"composite": true,
"outDir": "dist",
"allowSyntheticDefaultImports": true,
},
"allowJs": true,
"include": [
"app",
"actions",
"sources"
],
"exclude": [
"dist",
]
"extends": "../../tsconfig.components.json",
"include": [
"app",
"actions",
"sources",
"common"
],
"exclude": [
"dist"
],
"compilerOptions": {
"outDir": "./dist"
}
}
19 changes: 6 additions & 13 deletions components/buy_me_a_coffee/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,15 @@
{
"compilerOptions": {
"lib": ["es2020"],
"module": "ES2020",
"target": "ES2020",
"moduleResolution": "node",
"listEmittedFiles": true, // Used as a part of the build task, since we need to pass emitted files to our post-build script
"composite": true,
"outDir": "dist",
"allowSyntheticDefaultImports": true,
},
"allowJs": true,
"extends": "../../tsconfig.components.json",
"include": [
"app",
"actions",
"sources",
"common"
],
"exclude": [
"dist",
]
"dist"
],
"compilerOptions": {
"outDir": "./dist"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Ensure the composite flag (and any other previously-explicit options) still live in the shared config

Each component’s tsconfig.json used to declare "composite": true (and other build-critical options) locally. With the move to "extends": "../../tsconfig.components.json", those settings must now be defined in the shared file or tsc -b / incremental builds will break.

🏁 Script executed:

#!/bin/bash
# Sanity-check that the shared base config keeps the composite flag.
jq '.compilerOptions.composite' ../../tsconfig.components.json

Length of output: 151

🏁 Script executed:

#!/bin/bash
# Locate shared tsconfig file(s) in the repository
mapfile -t files < <(fd tsconfig.components.json)

if [ ${#files[@]} -eq 0 ]; then
  echo "No tsconfig.components.json found"
  exit 1
fi

for file in "${files[@]}"; do
  echo "=== $file ==="
  jq '.compilerOptions.composite' "$file" || echo "Unable to read composite flag in $file"
done

Length of output: 262

🏁 Script executed:

#!/bin/bash
set -e

echo "# Searching for tsconfig.components.json"
find . -type f -name "tsconfig.components.json" || echo "No tsconfig.components.json found"

echo
echo "# Searching for any JSON files with 'components' in the name"
find . -type f -iname "*components*.json" || echo "No JSON files with 'components' in name"

echo
echo "# Listing all tsconfig JSON files"
find . -type f -name "tsconfig*.json"

echo
echo "# Showing 'extends' entries in tsconfig JSON files"
grep -R -n --include 'tsconfig*.json' '"extends"' .

Length of output: 8859

🏁 Script executed:

#!/bin/bash
# Check whether the shared config declares composite (and other build-critical flags)
echo "## tsconfig.components.json compilerOptions"
jq '.compilerOptions' tsconfig.components.json

Length of output: 209

🏁 Script executed:

#!/bin/bash
# Grep for key build flags in tsconfig.components.json despite JSON syntax issues
echo "## Searching for 'composite' flag"
grep -R -n '"composite"' tsconfig.components.json || echo "composite not found"

echo
echo "## Searching for 'declaration' flag"
grep -R -n '"declaration"' tsconfig.components.json || echo "declaration not found"

echo
echo "## Searching for 'incremental' flag"
grep -R -n '"incremental"' tsconfig.components.json || echo "incremental not found"

Length of output: 564

Ensure all build-critical TS options live in tsconfig.components.json

The shared tsconfig.components.json already includes

  "composite": true

but the other flags—previously set in each component—are still missing. Without them, tsc -b/incremental builds will break. Please add at least:

 "compilerOptions": {
     "composite": true,
+    "declaration": true,
+    "incremental": true,
     /* …other shared options… */
 }
🤖 Prompt for AI Agents 
In components/buy_me_a_coffee/tsconfig.json lines 2 to 14, the file extends
tsconfig.components.json which includes "composite": true, but other essential
TypeScript build options required for incremental builds are missing. To fix
this, add the necessary build-critical compilerOptions such as "incremental":
true, "tsBuildInfoFile", and any other flags previously set in each component to
ensure tsc -b and incremental builds work correctly. These options should be
added under "compilerOptions" in this tsconfig.json.

}
19 changes: 6 additions & 13 deletions components/clientary/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,15 @@
{
"compilerOptions": {
"lib": ["es2020"],
"module": "ES2020",
"target": "ES2020",
"moduleResolution": "node",
"listEmittedFiles": true, // Used as a part of the build task, since we need to pass emitted files to our post-build script
"composite": true,
"outDir": "dist",
"allowSyntheticDefaultImports": true,
},
"allowJs": true,
"extends": "../../tsconfig.components.json",
"include": [
"app",
"actions",
"sources",
"common"
],
"exclude": [
"dist",
]
"dist"
],
"compilerOptions": {
"outDir": "./dist"
}
}
21 changes: 6 additions & 15 deletions components/cloudmersive/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,15 @@
{
"compilerOptions": {
"lib": [
"es2020"
],
"module": "ES2020",
"target": "ES2020",
"moduleResolution": "node",
"listEmittedFiles": true, // Used as a part of the build task, since we need to pass emitted files to our post-build script
"composite": true,
"outDir": "dist",
"allowSyntheticDefaultImports": true,
},
"allowJs": true,
"extends": "../../tsconfig.components.json",
"include": [
"app",
"actions",
"sources",
"common"
],
"exclude": [
"dist",
]
"dist"
],
"compilerOptions": {
"outDir": "./dist"
}
}
34 changes: 13 additions & 21 deletions components/coassemble/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,15 @@
{
"compilerOptions": {
"lib": [
"es2020"
],
"module": "ES2020",
"target": "ES2020",
"moduleResolution": "node",
"listEmittedFiles": true, // Used as a part of the build task, since we need to pass emitted files to our post-build script
"composite": true,
"outDir": "dist",
"allowSyntheticDefaultImports": true,
},
"allowJs": true,
"include": [
"app",
"actions",
"sources"
],
"exclude": [
"dist",
]
"extends": "../../tsconfig.components.json",
"include": [
"app",
"actions",
"sources",
"common"
],
"exclude": [
"dist"
],
"compilerOptions": {
"outDir": "./dist"
}
}
33 changes: 13 additions & 20 deletions components/concord/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,15 @@
{
"compilerOptions": {
"lib": ["es2020"],
"module": "ES2020",
"target": "ES2020",
"moduleResolution": "node",
"listEmittedFiles": true, // Used as a part of the build task, since we need to pass emitted files to our post-build script
"composite": true,
"outDir": "dist",
"allowSyntheticDefaultImports": true,
},
"allowJs": true,
"include": [
"app",
"actions",
"sources",
"common"
],
"exclude": [
"dist",
]
"extends": "../../tsconfig.components.json",
"include": [
"app",
"actions",
"sources",
"common"
],
"exclude": [
"dist"
],
"compilerOptions": {
"outDir": "./dist"
}
}
33 changes: 13 additions & 20 deletions components/currencyscoop/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,15 @@
{
"compilerOptions": {
"lib": ["es2020"],
"module": "ES2020",
"target": "ES2020",
"moduleResolution": "node",
"listEmittedFiles": true, // Used as a part of the build task, since we need to pass emitted files to our post-build script
"composite": true,
"outDir": "dist",
"allowSyntheticDefaultImports": true,
},
"allowJs": true,
"include": [
"app",
"actions",
"sources",
"common"
],
"exclude": [
"dist",
]
"extends": "../../tsconfig.components.json",
"include": [
"app",
"actions",
"sources",
"common"
],
"exclude": [
"dist"
],
"compilerOptions": {
"outDir": "./dist"
}
}
35 changes: 13 additions & 22 deletions components/data_axle_platform/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,15 @@
{
"compilerOptions": {
"lib": [
"es2020"
],
"module": "ES2020",
"target": "ES2020",
"moduleResolution": "node",
"listEmittedFiles": true, // Used as a part of the build task, since we need to pass emitted files to our post-build script
"composite": true,
"outDir": "dist",
"allowSyntheticDefaultImports": true,
},
"allowJs": true,
"include": [
"app",
"actions",
"sources",
"common"
],
"exclude": [
"dist",
]
"extends": "../../tsconfig.components.json",
"include": [
"app",
"actions",
"sources",
"common"
],
"exclude": [
"dist"
],
"compilerOptions": {
"outDir": "./dist"
}
}
Loading
Loading