-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Microsoft Power Bi - Get Reports #17997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughA new "Get Reports" action module was introduced for Microsoft Power BI, enabling retrieval of reports from a workspace by calling the Power BI API. The package version was incremented and the platform dependency updated. No other modules or files were changed. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GetReportsAction
participant MicrosoftPowerBiApp
participant PowerBiAPI
User->>GetReportsAction: Invoke run()
GetReportsAction->>MicrosoftPowerBiApp: _makeRequest('/reports', opts)
MicrosoftPowerBiApp->>PowerBiAPI: GET /reports
PowerBiAPI-->>MicrosoftPowerBiApp: Response (reports data)
MicrosoftPowerBiApp-->>GetReportsAction: Return reports data
GetReportsAction-->>User: Return reports list and summary
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Poem
Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (2)
components/microsoft_power_bi/actions/get-reports/get-reports.mjs (2)
24-26
: Align summary text with house style and keep pluralization.Prefer “Successfully retrieved …” per component conventions.
- $.export("$summary", `Found ${value.length} report${value.length === 1 - ? "" - : "s"}`); + $.export("$summary", `Successfully retrieved ${value.length} report${value.length === 1 ? "" : "s"}`);
21-23
: Defensive default to avoid runtime on unexpected payloads.If the API returns no
value
, destructuring can throw. Default to an empty array (already in the refactor above).- const { value } = await this.getReports({ + const { value = [] } = await this.getReports({ $, - }); + });
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
components/microsoft_power_bi/actions/get-reports/get-reports.mjs
(1 hunks)components/microsoft_power_bi/package.json
(2 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2024-12-12T19:23:09.039Z
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
Applied to files:
components/microsoft_power_bi/package.json
📚 Learning: 2024-10-08T15:33:38.240Z
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Applied to files:
components/microsoft_power_bi/actions/get-reports/get-reports.mjs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: pnpm publish
- GitHub Check: Lint Code Base
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
🔇 Additional comments (2)
components/microsoft_power_bi/package.json (2)
3-3
: Version bump is appropriate for new action addition.Increment to 0.4.0 aligns with adding a new action.
16-16
: No breaking changes detected after bumping to @pipedream/platform v3I verified that:
- The component’s package.json now references
"@pipedream/platform": "^3.1.0"
, matching several other components.- All uses of platform‐specific APIs (
$.export("$summary", …)
) remain valid under v3.- There are no calls to removed APIs (e.g.,
$.respond
) in this component.This upgrade is safe to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @michelle0927 lgtm! Ready for QA!
Resolves #17833
Summary by CodeRabbit
New Features
Chores