Update microsoft_outlook.app.mjs #19154
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
WalkthroughVersion bumps applied across 16 action modules and 4 source modules in the Microsoft Outlook component, plus package.json updated from 1.7.6 to 1.7.7. Additionally, the app module enhanced to support query-based user lookups and dynamic header merging functionality. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI as UI/Form
participant App as microsoft_outlook.app
participant API as Microsoft Graph API
rect rgb(240, 248, 255)
note over User,API: Query-Based User Lookup (New)
User->>UI: Enters search query
UI->>App: options({ query })
App->>App: Construct search params<br/>+ ConsistencyLevel header
App->>API: listUsers(searchParams)
API-->>App: Users matching query
App->>App: Map to value/label
App-->>UI: Display results
end
rect rgb(255, 250, 240)
note over User,API: Non-Query Lookup (Default)
User->>UI: Triggers user selection<br/>(no query)
UI->>App: options({ })
App->>API: listUsers()
API-->>App: All users
App->>App: Map to value/label
App-->>UI: Display results
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dannyroosevelt
moved this to Ready for PR Review
in Component (Source and Action) Backlog
|
Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified. |
|
Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
components/microsoft_outlook/microsoft_outlook.app.mjs (1)
198-218: Critical: Incorrect URL encoding breaks Microsoft Graph API search syntax.Line 203 encodes the entire search term including the property name and colon (
encodeURIComponent("displayName:" + query)), which causes double-encoding when passed to the HTTP client. Microsoft Graph API's$searchparameter expects the formatproperty:valuewith Boolean operators, and encoding the colon as%3Abreaks the expected syntax.Apply this diff to fix the search query construction:
- $search: `"${encodeURIComponent("displayName:" + query)}" OR "${encodeURIComponent("mail:" + query)}" OR "${encodeURIComponent("userPrincipalName:" + query)}"`, + $search: `"displayName:${encodeURIComponent(query)}" OR "mail:${encodeURIComponent(query)}" OR "userPrincipalName:${encodeURIComponent(query)}"`,This ensures only the user-provided query value is encoded while preserving the unencoded
property:valuesyntax required by the API.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (22)
components/microsoft_outlook/actions/add-label-to-email/add-label-to-email.mjs(1 hunks)components/microsoft_outlook/actions/approve-workflow/approve-workflow.mjs(1 hunks)components/microsoft_outlook/actions/create-contact/create-contact.mjs(1 hunks)components/microsoft_outlook/actions/create-draft-email/create-draft-email.mjs(1 hunks)components/microsoft_outlook/actions/download-attachment/download-attachment.mjs(1 hunks)components/microsoft_outlook/actions/find-contacts/find-contacts.mjs(1 hunks)components/microsoft_outlook/actions/find-email/find-email.mjs(1 hunks)components/microsoft_outlook/actions/find-shared-folder-email/find-shared-folder-email.mjs(1 hunks)components/microsoft_outlook/actions/list-contacts/list-contacts.mjs(1 hunks)components/microsoft_outlook/actions/list-folders/list-folders.mjs(1 hunks)components/microsoft_outlook/actions/list-labels/list-labels.mjs(1 hunks)components/microsoft_outlook/actions/move-email-to-folder/move-email-to-folder.mjs(1 hunks)components/microsoft_outlook/actions/remove-label-from-email/remove-label-from-email.mjs(1 hunks)components/microsoft_outlook/actions/reply-to-email/reply-to-email.mjs(1 hunks)components/microsoft_outlook/actions/send-email/send-email.mjs(1 hunks)components/microsoft_outlook/actions/update-contact/update-contact.mjs(1 hunks)components/microsoft_outlook/microsoft_outlook.app.mjs(2 hunks)components/microsoft_outlook/package.json(1 hunks)components/microsoft_outlook/sources/new-attachment-received/new-attachment-received.mjs(1 hunks)components/microsoft_outlook/sources/new-contact/new-contact.mjs(1 hunks)components/microsoft_outlook/sources/new-email-in-shared-folder/new-email-in-shared-folder.mjs(1 hunks)components/microsoft_outlook/sources/new-email/new-email.mjs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Verify TypeScript components
- GitHub Check: Publish TypeScript components
- GitHub Check: Lint Code Base
🔇 Additional comments (21)
components/microsoft_outlook/actions/find-contacts/find-contacts.mjs (1)
6-6: Version bump looks consistentAction version updated to
"0.0.20"only; format and progression are consistent with the rest of the Outlook actions in this PR.components/microsoft_outlook/actions/find-shared-folder-email/find-shared-folder-email.mjs (1)
7-7: Version metadata increment is fineThe action version bump to
"0.0.5"is isolated and consistent with the PR’s version-update pattern.components/microsoft_outlook/actions/update-contact/update-contact.mjs (1)
6-6: Contact action version bump is appropriate
"0.0.20"continues the existing scheme and is the only change in this file; safe to ship.components/microsoft_outlook/actions/remove-label-from-email/remove-label-from-email.mjs (1)
7-7: Label-removal action version updated correctlyVersion moved to
"0.0.13"with no behavioral diffs; aligns with neighboring label actions in this PR.components/microsoft_outlook/actions/list-folders/list-folders.mjs (1)
7-7: List Folders version bump is straightforwardUpdating to
"0.0.11"only affects metadata; no risk to runtime behavior.components/microsoft_outlook/actions/add-label-to-email/add-label-to-email.mjs (1)
8-8: Add-label action version increment is consistentVersion set to
"0.0.13"with no other modifications; consistent with related label actions.components/microsoft_outlook/actions/list-contacts/list-contacts.mjs (1)
6-6: List Contacts version bump is alignedMetadata version updated to
"0.0.20"only; aligns with other contact-related actions and looks good.components/microsoft_outlook/actions/approve-workflow/approve-workflow.mjs (1)
7-7: Approve Workflow action version updated safelyChanging the version to
"0.0.11"is purely metadata and consistent with other action bumps.components/microsoft_outlook/actions/send-email/send-email.mjs (1)
7-7: Version bump applied correctly.The patch version increment from 0.0.20 to 0.0.21 is consistent with the coordinated version updates across this PR.
components/microsoft_outlook/actions/move-email-to-folder/move-email-to-folder.mjs (1)
7-7: Version bump applied correctly.components/microsoft_outlook/actions/reply-to-email/reply-to-email.mjs (1)
7-7: Version bump applied correctly.components/microsoft_outlook/actions/create-contact/create-contact.mjs (1)
6-6: Version bump applied correctly.components/microsoft_outlook/sources/new-contact/new-contact.mjs (1)
8-8: Version bump applied correctly.components/microsoft_outlook/sources/new-email-in-shared-folder/new-email-in-shared-folder.mjs (1)
10-10: Version bump applied correctly.components/microsoft_outlook/actions/find-email/find-email.mjs (1)
7-7: Version bump applied correctly.components/microsoft_outlook/actions/list-labels/list-labels.mjs (1)
7-7: LGTM! Version bump aligns with package update.The version increment is consistent with the broader package release (1.7.7).
components/microsoft_outlook/package.json (1)
3-3: LGTM! Package version increment for release.The version bump from 1.7.6 to 1.7.7 aligns with the coordinated updates across action and source modules.
components/microsoft_outlook/sources/new-email/new-email.mjs (1)
10-10: LGTM! Version bump aligns with package update.The version increment is consistent with the broader package release.
components/microsoft_outlook/actions/create-draft-email/create-draft-email.mjs (1)
7-7: LGTM! Version bump aligns with package update.The version increment is consistent with the broader package release.
components/microsoft_outlook/sources/new-attachment-received/new-attachment-received.mjs (1)
9-9: LGTM! Version bump aligns with package update.The version increment is consistent with the broader package release.
components/microsoft_outlook/microsoft_outlook.app.mjs (1)
272-278: LGTM! Header merging implementation is correct.The optional
headersparameter and spread-merge pattern properly support dynamic header injection, enabling theConsistencyLevelheader required for user search queries.
components/microsoft_outlook/actions/download-attachment/download-attachment.mjs
Show resolved
Hide resolved
For Integration QA: |
5 participants
WHY
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.