Refactor show graph, allow for explicit calling of formats, add interactive widget for Jupyter #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkpaine
added
the
type: enhancement
timkpaine
requested review from
AdamGlustein,
alexddobkin,
robambalu and
svatasoiu
as code owners
timkpaine
force-pushed
the
tkp/graphvisua
branch
from
5118db8 to
87923c7
Compare
|
It takes longer to create the graph widget, but once created, it renders much faster. Using the 16 bit nand computer as an example "large" graph, Preview has issues showing the png, whereas the widget displays it fluidly. Note that the blurring and tearing is NOT gif recording artifacts, but due to Preview. During the mouse shaking, Preview is frozen (the spinning pinwheel is displayed but doesn't show on the recording).
|
timkpaine
force-pushed
the
tkp/graphvisua
branch
2 times, most recently
from
723d2bc to
c1d7eae
Compare
robambalu
reviewed
May 8, 2024
timkpaine
force-pushed
the
tkp/graphvisua
branch
2 times, most recently
from
b4b4cb0 to
ae89775
Compare
|
Note that I'm planning on moving this to daggre so that we can use the interactive visualization outside of Jupyter. |
robambalu
requested changes
Jun 18, 2024
csp/showgraph.py
Outdated
| image.show() | ||
|
|
||
|
|
||
| def show_graph_graphviz(graph_func, *args, graph_filename=None, interactive=False, **kwargs): |
…active widget for jupyter Signed-off-by: Tim Paine <[email protected]>
timkpaine
force-pushed
the
tkp/graphvisua
branch
from
ec7ef09 to
25df545
Compare
…via graphviz by default Signed-off-by: Tim Paine <[email protected]>
timkpaine
force-pushed
the
tkp/graphvisua
branch
from
25df545 to
0ed0c52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title.
Allows for explicit calling of:
show_graph_pilshow_graph_graphvizAdds:
show_graph_widget: uses ipydagred3 which was written explicitly for use withcspModifies:
show_graphto check if in Jupyter, and if so, either use the new widget display or return theDigraphfor inline viewingA small unrelated change is included: Replacing base
Exceptioninsymphony.pyandprofiler.pywithRuntimeErrorandModuleNotFoundError, respectively.