Skip to content

LogHog -> PostHog #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: v2.0.0-branch
Choose a base branch
from

Conversation

martosaur
Copy link

It feels weird to create a PR that basically replaces everything, but here we are 🫠 The code is pretty much identical to martosaur/log_hog#18 The biggest key question I think is which big parts of the original should survive.

We probably want to have a temporary branch for that too, since there is a definitely a list of things that should be done before this goes through, if it does at all. For example:

  • Partitioning Sender, so that a single process wouldn't become a bottleneck. I think Sentry's event sender is a decent example
  • Ensuring that the library plays well with users' async tests
  • Clearly splitting high level functions into "convenience functions with reasonable defaults" and lower-level DIY-kit (PostHog.Core for example?)

Anyways, I'm leaving this up to you @rafaeelaudibert to outline the path forward , I'll do what I can to help.

Copy link
Member

@rafaeelaudibert rafaeelaudibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of changes needed in this PR before we merge it. I'm happy to do them in this PR rather than waiting for you @martosaur since I know you're fairly busy. I've pointed this to a new v2.0.0 feature branch so that I/we can develop against that branch safely.

@martosaur Can you make sure I have write access to the parent log-hog-invasion (😆) branch?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this one? It seems like this should be covered by integration.example.exs

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right! It should be gitignored 😅 luckily this is a public token

@rafaeelaudibert rafaeelaudibert changed the base branch from master to v2.0.0-branch July 15, 2025 14:06
@martosaur martosaur force-pushed the am-log-hog-invasion branch from d512b8c to 196c732 Compare July 16, 2025 02:39
martosaur and others added 3 commits July 15, 2025 19:39
Co-authored-by: Rafael Audibert <[email protected]>
Co-authored-by: Rafael Audibert <[email protected]>
@martosaur
Copy link
Author

@rafaeelaudibert that's a very short list so all done! But feel free to poke around more

Can you make sure I have write access to the parent log-hog-invasion (😆) branch?

I added you as a contributor to my fork so I think that should do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants