feat(devex): scene layout (dashboards) #35207
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Greptile Summary
This PR implements a new scene layout system for the dashboard header, as part of a larger initiative to convert all products to use a minimal layout pattern. The changes primarily affect the dashboard header component and several supporting scene components, introducing a new panel-based layout to replace traditional dropdown menus. Key changes include:
- Converting the dashboard header to use
<SceneLayout>component - Modifying
SceneCommonButtonsto support pin and fullscreen actions - Making
SceneNotificationDropdownMenumore flexible to handle both dashboard and insight notifications - Adding feature flag
NEW_SCENE_LAYOUTfor controlled rollout - Updating
SceneTagsto support both editable and read-only states
The PR maintains backward compatibility through feature flags while modernizing the UI structure.
Confidence score: 3/5
- Safe to merge with careful monitoring of the feature flag rollout
- Score reflects concerns about manual-only testing and potential edge cases in notification handling
- The
DashboardHeader.tsxandSceneNotificationDropdownMenu.tsxfiles need particular attention due to type assertions and complex state management
4 files reviewed, 5 comments
Edit PR Review Bot Settings | Greptile
frontend/src/lib/components/Scenes/InsightOrDashboard/SceneNotificationDropdownMenu.tsx
Outdated
Show resolved
Hide resolved
|
Size Change: 0 B Total Size: 2.61 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
adamleithp
force-pushed
the
devex/scene-layout-dashboards
branch
from
2d3bb46 to
fba315c
Compare
📸 UI snapshots have been updated10 snapshot changes in total. 0 added, 10 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated18 snapshot changes in total. 0 added, 18 modified, 0 deleted:
Triggered by this commit. |
adamleithp
force-pushed
the
devex/scene-layout-dashboards
branch
from
2a66da7 to
1c36601
Compare
📸 UI snapshots have been updated10 snapshot changes in total. 0 added, 10 modified, 0 deleted:
Triggered by this commit. |
Problem
Converting all products to new minimal layout
Changes
Add
<SceneLayout>to dashboard header, recreate any buttons in there/ or re-use commoncomponents/Scenes/components. Hide page captions and More dropdowns.How did you test this code?
Manually
Did you write or update any docs for this change?