fix: unblock signup when GitHub Releases is down#387
Draft
Conversation
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Results will be posted here when complete. |
MattBro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Allow
--signupruns to continue past the blocking outage screen even whenGitHub Releasesis down.The health check warning still appears, but signup users now get a
Continue anywaypath instead of being forced to exit.Why
The published wizard currently blocks before account provisioning when
GitHub Releasesis unavailable, even though the provisioning flow itself only needs PostHog's signup/provisioning APIs.That makes the new-account flow fail before it ever reaches
provisionNewAccount, which is the wrong dependency boundary for signup.Impact
New users can still create a PostHog account during an outage affecting skill downloads.
The later integration step may still be impacted by external outages, but account creation is no longer blocked by an unrelated GitHub Releases check.
Root cause
HealthCheckScreenspecial-casedgithubReleasesoutages to remove theContinueaction entirely. That behavior applied to signup runs too, so the wizard exited before auth/provisioning.Validation
jest src/ui/tui/screens/health/HealthCheckScreen.test.tsx --runInBandNotes
A broader follow-up could split readiness checks by phase so signup only blocks on services it actually depends on.