auth: more RFC3597 conformance - #17763
Open
miodvallat wants to merge 1 commit into
Open
Conversation
Coverage Report for CI Build 29920875492Coverage increased (+0.05%) to 71.146%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions27 previously-covered lines in 10 files lost coverage.
Coverage Stats💛 - Coveralls |
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
Contributor
Author
|
Fixes: #804 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This PR allows records of known type to be provided as raw data, in
\#format.In order to achieve this:
PacketReaderis modified to add a "standalone" mode, in which no header exists before the payload, and no attempt is made to handle compressed DNS names (as compression only works within an entire packet).UnknownRecordContentfirst, then feed the resulting raw data to aPacketReaderin standalone mode and then parse the record with the intended type, from thePacketReader.Checklist
I have: