Skip to content

dnsdist-2.1: Backport 17747 - Gracefully handle errors in DynBlock's suffix match policy - #17929

Merged
rgacogne merged 1 commit into
PowerDNS:rel/dnsdist-2.1.xfrom
rgacogne:ddist21-backport-17747
Aug 25, 2026
Merged

dnsdist-2.1: Backport 17747 - Gracefully handle errors in DynBlock's suffix match policy#17929
rgacogne merged 1 commit into
PowerDNS:rel/dnsdist-2.1.xfrom
rgacogne:ddist21-backport-17747

Conversation

@rgacogne

Copy link
Copy Markdown
Member

Short description

Backport #17747 to dnsdist-2.1.x

There is no need to stop the whole processing if we choked on one entry, or even could not properly insert one new rule.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

There is no need to stop the whole processing if we choked on one entry,
or even could not properly insert one new rule.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 54649c5)
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 32744122840

Coverage decreased (-0.01%) to 68.87%

Details

  • Coverage decreased (-0.01%) from the base build.
  • Patch coverage: 8 uncovered changes across 1 file (22 of 30 lines covered, 73.33%).
  • 3 coverage regressions across 2 files.

Uncovered Changes

File Changed Covered %
pdns/dnsdistdist/dnsdist-dynblocks.cc 30 22 73.33%

Coverage Regressions

3 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
pdns/dnsdistdist/dnsdist-async.cc 2 77.04%
pdns/dnsdistdist/dnsdist-dynblocks.cc 1 65.8%

Coverage Stats

Coverage Status
Relevant Lines: 71341
Covered Lines: 54397
Line Coverage: 76.25%
Relevant Branches: 30998
Covered Branches: 16084
Branch Coverage: 51.89%
Branches in Coverage %: Yes
Coverage Strength: 2239448.07 hits per line

💛 - Coveralls

@rgacogne
rgacogne merged commit c179f69 into PowerDNS:rel/dnsdist-2.1.x Aug 25, 2026
18 checks passed
@rgacogne
rgacogne deleted the ddist21-backport-17747 branch August 25, 2026 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants