Repository navigation
Run tests for PR #2019 - #2062
Open
alerickson wants to merge 7 commits into
Open
alerickson wants to merge 7 commits into
alerickson wants to merge 7 commits into
Conversation
… 1657) Co-authored-by: et1975 <623703+et1975@users.noreply.github.com>
Co-authored-by: et1975 <623703+et1975@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 434a152d-b80d-4a4d-946e-3c9c45e2ba78
…of matching the version text in the packageContent URL
alerickson
requested review from
Sydney Smith (SydneyhSmith),
Aditya Patwardhan (adityapatwardhan),
Anam Navied (anamnavi) and
shammu1
as code owners
October 6, 2026 18:13
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation addresses URL-substring ambiguity with focused coverage and no unresolved issues found.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes V3 package URL selection by comparing parsed NuGet versions instead of URL substrings.
Changes:
- Selects exact or latest package entries independent of URL format and ordering.
- Adds focused Pester coverage for version-selection edge cases.
- Moves shared test hooks into a dedicated class.
| File | Description |
|---|---|
src/code/V3ServerAPICalls.cs |
Parses registration entries and selects package URLs by version. |
src/code/TestHooks.cs |
Centralizes test-accessible internal helpers. |
src/code/PSResourceInfo.cs |
Removes the relocated test hooks. |
test/InstallPSResourceTests/InstallPSResourceV3ServerVersionSelection.Tests.ps1 |
Tests exact, normalized, prerelease, malformed, and latest-version selection. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
…sync when installing packages in parallel
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
5 of 14 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.