feat: Watch Party sync script system - #10612
Conversation
Add the sync script infrastructure for Watch Party video synchronization: - Sync script compiler and CLI commands (sync-new, sync-dev, sync-build) - YouTube and Disney+ sync script implementations - Global type definitions for SyncScriptV1, SyncIframeScriptV1, SyncMainworldScriptV1 - Comprehensive developer documentation (guide, API reference, examples) - .gitignore rules for syncScripts build artifacts
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
- Fix markdown table alignment in documentation - Add explicit `import process from 'node:process'` in SyncScriptCompiler
The getChangedActivities walker was treating sync script directories as activities because they contain metadata.json. Add syncScripts/ to the endAt list so the walker stops before matching them.
The previous fix added syncScripts to endAt, but that only applies when metadata.json is NOT found. Since sync scripts have their own metadata.json, the walker finds it immediately. Skip files under syncScripts/ entirely before the walk loop.
Convert method signatures to function property syntax to satisfy ts/method-signature-style ESLint rule.
theusaf
added
the
repo maintenance
|
This PR has been marked as stale because it has been inactive for over 14 days. |
github-actions
Bot
added
the
inactive
Bas950
removed
the
inactive
|
This PR has been marked as stale because it has been inactive for over 14 days. |
github-actions
Bot
added
the
inactive
theusaf
removed
the
inactive
|
This PR has been marked as stale because it has been inactive for over 14 days. |
github-actions
Bot
added
the
inactive
Bas950
removed
the
inactive
|
This PR has been marked as stale because it has been inactive for over 14 days. |
github-actions
Bot
added
the
inactive
theusaf
removed
the
inactive
|
This PR has been marked as stale because it has been inactive for over 14 days. |
github-actions
Bot
added
the
inactive
Bas950
removed
the
inactive
|
This PR has been marked as stale because it has been inactive for over 14 days. |
github-actions
Bot
added
the
inactive
Bas950
removed
the
inactive
|
This PR has been marked as stale because it has been inactive for over 14 days. |
github-actions
Bot
added
the
inactive
skullysmods
removed
the
inactive
|
This PR has been marked as stale because it has been inactive for over 14 days. |
github-actions
Bot
added
the
inactive
skullysmods
removed
the
inactive
|
This PR has been marked as stale because it has been inactive for over 14 days. |
github-actions
Bot
added
the
inactive
Bas950
removed
the
inactive
5 participants
Summary
Adds the complete sync script infrastructure for Watch Party video synchronization across party members.
sync-new,sync-dev,sync-buildcommands with hot-reload dev server and compilerSyncScriptV1,SyncIframeScriptV1,SyncMainworldScriptV1and all related interfaces.gitignorerules for syncScripts build artifactsTest plan
pnpm sync-dev YouTubestarts dev server with hot reloadpnpm sync-build --allcompiles all sync scripts to dist/pnpm sync-new "ExampleService"scaffolds a new sync scriptcd docs && pnpm dev