Skip to content

Add missing endpoints about discounts #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2025
Merged

Add missing endpoints about discounts #86

merged 1 commit into from
Oct 27, 2025

Conversation

@nicosomb
Copy link
Contributor

@nicosomb nicosomb commented Oct 17, 2025 •
edited by Progi1984
Loading

Questions Answers
Description? Add missing endpoints about discounts
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? PrestaShop/PrestaShop#39682
Sponsor company PrestaShop SA
How to test? The new endpoints are available here PrestaShop/PrestaShop#39682 We have to see if they are ok

@nicosomb nicosomb force-pushed the missing-endpoints branch 7 times, most recently from 3fdddfc to 147ca93 Compare October 17, 2025 15:19
@github-project-automation github-project-automation bot moved this to Ready for review in PR Dashboard Oct 20, 2025
@nicosomb nicosomb requested review from boherm and tleon October 20, 2025 13:05
boherm
boherm previously approved these changes Oct 20, 2025
View reviewed changes
@ps-jarvis ps-jarvis added the Waiting for QA Status: Waiting for QA feedback label Oct 20, 2025
@ps-jarvis ps-jarvis moved this from Ready for review to To be tested in PR Dashboard Oct 20, 2025
@tyloo
Copy link

tyloo commented Oct 21, 2025

I think we miss tests here :)

@nicosomb nicosomb added Waiting for author and removed Waiting for QA Status: Waiting for QA feedback labels Oct 21, 2025
@ps-jarvis ps-jarvis moved this from To be tested to Waiting for author in PR Dashboard Oct 21, 2025
@nicosomb nicosomb force-pushed the missing-endpoints branch 3 times, most recently from 42a4514 to 69185ef Compare October 21, 2025 12:24
@nicosomb nicosomb requested a review from boherm October 21, 2025 13:39
tleon
tleon requested changes Oct 21, 2025
View reviewed changes
boherm
boherm previously approved these changes Oct 23, 2025
View reviewed changes
@ps-jarvis ps-jarvis added the Waiting for QA Status: Waiting for QA feedback label Oct 23, 2025
@ps-jarvis ps-jarvis moved this from Waiting for author to To be tested in PR Dashboard Oct 23, 2025
@nicosomb nicosomb requested review from boherm and tleon October 23, 2025 12:57
tleon
tleon previously approved these changes Oct 23, 2025
View reviewed changes
@nicosomb nicosomb requested a review from tleon October 23, 2025 15:58
@SiraDIOP SiraDIOP self-assigned this Oct 27, 2025
@SiraDIOP
Copy link

Hello @nicosomb,

Thanks for your PR

I tested it and it's good for me :)

PATCH: http://localhost:8001/admin-api/discount/1
Capture d’écran 2025-10-27 à 10 52 13

PATCH http://localhost:8001/admin-api/discount/2/conditions

Capture d’écran 2025-10-27 à 11 00 28

Thanks

@SiraDIOP SiraDIOP added QA ✔️ Status: QA-Approved and removed Waiting for QA Status: Waiting for QA feedback labels Oct 27, 2025
@nicosomb nicosomb merged commit a862536 into dev Oct 27, 2025
26 checks passed
@github-project-automation github-project-automation bot moved this from To be tested to Merged in PR Dashboard Oct 27, 2025
@ps-jarvis ps-jarvis moved this from Merged to To be tested in PR Dashboard Oct 27, 2025
@ps-jarvis
Copy link

PR merged, well done!

Message to @PrestaShop/committers: do not forget to milestone it before the merge.

@nicosomb nicosomb added this to the 0.2.0 milestone Oct 27, 2025
@nicosomb
Copy link
Contributor Author

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boherm boherm boherm approved these changes

@SiraDIOP SiraDIOP SiraDIOP approved these changes

@tleon tleon Awaiting requested review from tleon

Assignees

@SiraDIOP SiraDIOP

Labels

QA ✔️ Status: QA-Approved

Projects

PR Dashboard
Status: To be tested

Milestone

0.2.0

Development

Successfully merging this pull request may close these issues.

8 participants

@nicosomb @tyloo @SiraDIOP @ps-jarvis @tleon @boherm @kpodemski