Skip to content

Refactor base API URL assignment to use useEffect #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
Merged

Refactor base API URL assignment to use useEffect #1003

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/pxweb2/src/app/pages/TableViewer/TableViewer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@ export function TableViewer() {
const config = getConfig();
const accessibility = useAccessibility();

const baseUrl = config.apiUrl;
OpenAPI.BASE = baseUrl;

const { tableId } = useParams<{ tableId: string }>();
const [selectedTableId] = useState(tableId ?? '');
const [selectedNavigationView, setSelectedNavigationView] =
Expand All @@ -53,6 +50,13 @@ export function TableViewer() {
const hideMenuRef = useRef<HTMLButtonElement>(null);
const skipToMainRef = useRef<HTMLDivElement>(null);

// Set base URL for API client
const baseUrl = config.apiUrl;

useEffect(() => {
OpenAPI.BASE = baseUrl;
}, [baseUrl]);

useEffect(() => {
if (hasFocus !== 'none' && navigationBarRef.current) {
hideMenuRef.current?.focus();
Expand Down
Loading